From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Linux Input <linux-input@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/6] i2c: Make remove callback return void
Date: Fri, 8 Jul 2022 21:28:27 -0700 [thread overview]
Message-ID: <YskD6/4iDgiIkV2G@google.com> (raw)
In-Reply-To: <20220628140313.74984-7-u.kleine-koenig@pengutronix.de>
On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <uwe@kleine-koenig.org>
>
> The value returned by an i2c driver's remove function is mostly ignored.
> (Only an error message is printed if the value is non-zero that the
> error is ignored.)
>
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour, all callbacks were prepared to
> return 0 before.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
...
> drivers/input/joystick/as5011.c | 4 +---
> drivers/input/keyboard/adp5588-keys.c | 4 +---
> drivers/input/keyboard/lm8323.c | 4 +---
> drivers/input/keyboard/lm8333.c | 4 +---
> drivers/input/keyboard/mcs_touchkey.c | 4 +---
> drivers/input/keyboard/qt1070.c | 4 +---
> drivers/input/keyboard/qt2160.c | 4 +---
> drivers/input/keyboard/tca6416-keypad.c | 4 +---
> drivers/input/misc/adxl34x-i2c.c | 4 +---
> drivers/input/misc/bma150.c | 4 +---
> drivers/input/misc/cma3000_d0x_i2c.c | 4 +---
> drivers/input/misc/pcf8574_keypad.c | 4 +---
> drivers/input/mouse/synaptics_i2c.c | 4 +---
> drivers/input/rmi4/rmi_smbus.c | 4 +---
> drivers/input/touchscreen/atmel_mxt_ts.c | 4 +---
> drivers/input/touchscreen/bu21013_ts.c | 4 +---
> drivers/input/touchscreen/cyttsp4_i2c.c | 4 +---
> drivers/input/touchscreen/edt-ft5x06.c | 4 +---
> drivers/input/touchscreen/goodix.c | 4 +---
> drivers/input/touchscreen/migor_ts.c | 4 +---
> drivers/input/touchscreen/s6sy761.c | 4 +---
> drivers/input/touchscreen/stmfts.c | 4 +---
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thanks.
--
Dmitry
parent reply other threads:[~2022-07-09 4:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220628140313.74984-7-u.kleine-koenig@pengutronix.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YskD6/4iDgiIkV2G@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox