From: Christoph Hellwig <hch@infradead.org>
To: Yixun Lan <dlan@gentoo.org>
Cc: Christoph Hellwig <hch@infradead.org>, Yonghong Song <yhs@fb.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Alan Maguire <alan.maguire@oracle.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
linux-riscv@lists.infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH] RISC-V/bpf: Enable bpf_probe_read{, str}()
Date: Sun, 10 Jul 2022 20:58:17 -0700 [thread overview]
Message-ID: <Ysuf2ZiZ5RSFnQOD@infradead.org> (raw)
In-Reply-To: <YslAxaryvm/MfGbq@ofant>
On Sat, Jul 09, 2022 at 04:48:05PM +0800, Yixun Lan wrote:
> never mind, I think the logic is quite clear, we can do something in bcc:
>
> 1) adopt new _{kernel,user} interface whenever possible, this will
> work fine for all arch with new kernel versions
>
> 2) for old kernel versions which lack the _{kernel,user} support,
> fall back to old bpf_probe_read(), but take care of the Archs which
> have overlaping address space - like s390, and just error out for it
Yes, that is the right thing to do.
next prev parent reply other threads:[~2022-07-11 3:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-03 13:09 [PATCH] RISC-V/bpf: Enable bpf_probe_read{, str}() Yixun Lan
2022-07-03 13:12 ` Conor Dooley
2022-07-04 2:20 ` Yixun Lan
2022-07-04 6:29 ` Conor.Dooley
2022-07-04 5:53 ` Christoph Hellwig
2022-07-06 5:00 ` Andrii Nakryiko
2022-07-06 6:41 ` Yonghong Song
2022-07-06 7:01 ` Christoph Hellwig
2022-07-09 1:01 ` Yixun Lan
2022-07-09 6:24 ` Christoph Hellwig
2022-07-09 8:48 ` Yixun Lan
2022-07-11 3:58 ` Christoph Hellwig [this message]
2022-07-06 7:00 ` Christoph Hellwig
2022-07-08 22:22 ` Andrii Nakryiko
2022-07-09 6:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ysuf2ZiZ5RSFnQOD@infradead.org \
--to=hch@infradead.org \
--cc=alan.maguire@oracle.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dlan@gentoo.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox