public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Binyi Han <dantengknight@gmail.com>
Cc: Manish Chopra <manishc@marvell.com>,
	GR-Linux-NIC-Dev@marvell.com, Coiby Xu <coiby.xu@gmail.com>,
	Joe Perches <joe@perches.com>,
	netdev@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: qlge: Fix indentation issue under long for loop
Date: Mon, 11 Jul 2022 10:05:12 +0200	[thread overview]
Message-ID: <YsvZuPkbwe8yX8oi@kroah.com> (raw)
In-Reply-To: <20220710210418.GA148412@cloud-MacBookPro>

On Sun, Jul 10, 2022 at 02:04:18PM -0700, Binyi Han wrote:
> Fix indentation issue to adhere to Linux kernel coding style,
> Issue found by checkpatch. Change the long for loop into 3 lines. And
> optimize by avoiding the multiplication.
> 
> Signed-off-by: Binyi Han <dantengknight@gmail.com>
> ---
> v2:
> 	- Change the long for loop into 3 lines.
> v3:
> 	- Align page_entries in the for loop to open parenthesis.
> 	- Optimize by avoiding the multiplication.

Please do not mix coding style fixes with "optimizations" or logical
changes.  This should be multiple patches.

Also, did you test this change on real hardware?  At first glance, it's
not obvious that the code is still doing the same thing, so "proof" of
that would be nice to have.

thanks,

greg k-h

  reply	other threads:[~2022-07-11  8:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-10 21:04 [PATCH v3] staging: qlge: Fix indentation issue under long for loop Binyi Han
2022-07-11  8:05 ` Greg Kroah-Hartman [this message]
2022-07-11 20:55   ` Joe Perches
2022-07-12  9:44     ` Greg Kroah-Hartman
2022-07-13  8:14       ` binyi
2022-07-12 13:46 ` Dan Carpenter
2022-07-12 14:14   ` Joe Perches
2022-07-15  6:04     ` binyi
2022-07-15  9:28       ` Dan Carpenter
2022-07-18  2:12         ` binyi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YsvZuPkbwe8yX8oi@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=GR-Linux-NIC-Dev@marvell.com \
    --cc=coiby.xu@gmail.com \
    --cc=dantengknight@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=manishc@marvell.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox