public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Cameron Williams <cang1@live.co.uk>
Cc: jirislaby@kernel.org, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: 8250: Add support for Brainboxes PX cards.
Date: Mon, 11 Jul 2022 16:33:19 +0200	[thread overview]
Message-ID: <Ysw0r9xSrbx188xe@kroah.com> (raw)
In-Reply-To: <AM5PR0202MB2564E7101DA29351041CB4C9C4879@AM5PR0202MB2564.eurprd02.prod.outlook.com>

On Mon, Jul 11, 2022 at 02:50:35PM +0100, Cameron Williams wrote:
> Add support for some of the Brainboxes PCIe (PX) range of
> serial cards, including the PX-101, PX-235/PX-246,
> PX-203/PX-257, PX-260/PX-701, PX-310, PX-313,
> PX-320/PX-324/PX-376/PX-387, PX-335/PX-346, PX-368, PX-420,
> PX-803 and PX-846.
> 
> Signed-off-by: Cameron Williams <cang1@live.co.uk>
> ---
>  drivers/tty/serial/8250/8250_pci.c | 116 ++++++++++++++++++++++++++++-
>  1 file changed, 113 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> index a17619db7939..4a0ea79ca9d6 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -4973,7 +4973,7 @@ static const struct pci_device_id serial_pci_tbl[] = {
>  	/*
>  	* Brainboxes UC-101
>  	*/
> -	{       PCI_VENDOR_ID_INTASHIELD, 0x0BA1,
> +	{	PCI_VENDOR_ID_INTASHIELD, 0x0BA1,

You seem to have included a bunch of no-needed whitespace changes.  Can
you redo this to only make the additional device id support instead?

thanks,

greg k-h

      reply	other threads:[~2022-07-11 14:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-11 13:50 [PATCH] tty: 8250: Add support for Brainboxes PX cards Cameron Williams
2022-07-11 14:33 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ysw0r9xSrbx188xe@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=cang1@live.co.uk \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox