Re: [PATCH 3/3] i2c: qcom-geni: Silence NACK and GENI_TIMEOUT

Vinod Koul
2022-07-18T05:37:12Z

On 16-07-22, 20:50, Bjorn Andersson wrote:
> Turn NACK and GENI_TIMEOUT into debug prints to silence the kernel log
> when running things such as i2cdetect to scan the bus.

Reviewed-by: Vinod Koul <vkoul@kernel.org>

>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/i2c/busses/i2c-qcom-geni.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
> index e212e7ae7ad2..6ac179a373ff 100644
> --- a/drivers/i2c/busses/i2c-qcom-geni.c
> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
> @@ -208,6 +208,10 @@ static void geni_i2c_err(struct geni_i2c_dev *gi2c, int err)
> case GENI_ABORT_DONE:
> gi2c->abort_done = true;
> break;
> + case NACK:
> + case GENI_TIMEOUT:
> + dev_dbg(gi2c->se.dev, "%s\n", gi2c_log[err].msg);
> + break;
> default:
> dev_err(gi2c->se.dev, "%s\n", gi2c_log[err].msg);
> geni_i2c_err_misc(gi2c);
> --
> 2.35.1

--
~Vinod