Re: [PATCH 3/3] i2c: qcom-geni: Silence NACK and GENI_TIMEOUT

Wolfram Sang
2022-07-24T05:23:22Z

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

On Sat, Jul 16, 2022 at 08:50:27PM -0700, Bjorn Andersson wrote:
> Turn NACK and GENI_TIMEOUT into debug prints to silence the kernel log
> when running things such as i2cdetect to scan the bus.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

As mentioned, I squashed it with the previous patch.

> + case NACK:
> + case GENI_TIMEOUT:
> + dev_dbg(gi2c->se.dev, "%s\n", gi2c_log[err].msg);
> + break;

Additional note: the dbg messages in this function are superfluous. We
already have all this information with the tracepoints in i2c_transfer.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]