Re: [PATCH 1/3] i2c: qcom-geni: Use the correct return value

Wolfram Sang
2022-07-24T05:04:26Z

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

> - return num;
> + return ret;

Not quite. Kdoc describes the retval in i2c_transfer.

2136 * i2c_transfer - execute a single or combined I2C message
2137 * @adap: Handle to I2C bus
2138 * @msgs: One or more messages to execute before STOP is issued to
2139 * terminate the operation; each message begins with a START.
2140 * @num: Number of messages to be executed.
2141 *
2142 * Returns negative errno, else the number of messages executed.

I agree this needs better documentation in i2c.h, I will fix it.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]