From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24498C433EF for ; Mon, 25 Jul 2022 12:15:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234975AbiGYMPU (ORCPT ); Mon, 25 Jul 2022 08:15:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232143AbiGYMPR (ORCPT ); Mon, 25 Jul 2022 08:15:17 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25179AE62; Mon, 25 Jul 2022 05:15:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AFF47B80E8C; Mon, 25 Jul 2022 12:15:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C897C341C6; Mon, 25 Jul 2022 12:15:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658751313; bh=ND6sJqpmi/ZIFCyzo6WuKYHiyg2EE+4CRPxEUCsFK3s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QHMLAVVLDYRp1oaAJv87qeUzZKi963pn9yJ4TdIiLgyUPXJ7maR0JSYzRCsz5bCA3 SIOtEFw/sCupJThINvfy+WST8Uc1ViiP37DrbnMBvOsIJzzNH+7JxvsQFPN211iR8J n0x8H0/5Z9Eig7SjFQbnQC2V5g5zH/+gLClyJbX55c5TpDu3i5p3hgRpMYEewn8fwh bnorhXsU/j3PhW04nzy082yFIt1nxIvdpEcwFhufodneJKMRQ8bOkgTSTh1P7yLu3V CtlftF9xzaq+9tGqYAfV+xMCVhlzeFAGmMY6uti4aCaHRtYlCH5RH+3wbf9LvT1INZ ZzrGzsumXOl4A== Date: Mon, 25 Jul 2022 13:15:06 +0100 From: Mark Brown To: Tomer Maimon Cc: Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , OpenBMC Maillist , linux-spi@vger.kernel.org, Linux Kernel Mailing List , devicetree Subject: Re: [PATCH v1 1/2] spi: npcm-pspi: add full duplex support Message-ID: References: <20220721101556.118568-1-tmaimon77@gmail.com> <20220721101556.118568-2-tmaimon77@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xAtPP1KaYCL3Kz0X" Content-Disposition: inline In-Reply-To: X-Cookie: Replace with same type. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xAtPP1KaYCL3Kz0X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jul 24, 2022 at 12:35:37PM +0300, Tomer Maimon wrote: > On Thu, 21 Jul 2022 at 16:46, Mark Brown wrote: > > On Thu, Jul 21, 2022 at 01:15:55PM +0300, Tomer Maimon wrote: > > > This patch adds full duplex support for NPCM PSPI driver by storing all > > > rx-data when the Rx-buffer is defined also for TX-buffer handling. > > This doesn't seem to entirely correspond to what the patch does, nor to > > what the driver currently does? I can't see any dummy read code in the > > current driver. > In the current handler file, in the handler function. > static irqreturn_t npcm_pspi_handler(int irq, void *dev_id) > - if (priv->tx_buf) { > - if (stat & NPCM_PSPI_STAT_RBF) { > - ioread8(NPCM_PSPI_DATA + priv->base); > the read above doing a dummy read That's reading a single byte, not an entire buffer, and from a quick glance looks more like an ack. Though perhaps you just end up with a lot of interrupts and do that anyway. --xAtPP1KaYCL3Kz0X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLeiUkACgkQJNaLcl1U h9BdCQf/QdlNiAcmCougz2zZbczwVhrOeD9z3yH0yaWm4vI2eCWPVZ8A8YdC/oYC hyo8qoU5Aa4cSorcJ0cTQf+P5mbi18i67ZMCTkSIhMGMpo1ozHNMX5RvD7ykhUNQ hMZUpNohI+yjLHhGaGzZhROgKbmuvwnacC7fBUmcOKDnwpoy7z346AgP0usZkt8w 6tz5ffXZvBfOTBZ9iOXo7xtv+YvMekDS0DEyZCo1O92gcWlJgV/xanBOTBR+ba2E tDeIxu1gForYMOKwGHeHKpFG8uIy/qeNRx2gOV9YW5yV9iFtax+zdJBcjrPmFGKI wsXb4i/iIfSCpPAftoTR8IjOjzUGng== =GWj5 -----END PGP SIGNATURE----- --xAtPP1KaYCL3Kz0X--