From: Greg KH <gregkh@linuxfoundation.org>
To: tury <renyu@nfschina.com>
Cc: keescook@chromium.org, arnd@arndb.de,
linux-kernel@vger.kernel.org, liqiong@nfschina.com,
yuzhe@nfschina.com
Subject: Re: [PATCH 2/3] lkdtm/perms: Check possible NULL pointer returned by kmalloc(),vmalloc()
Date: Mon, 25 Jul 2022 14:37:05 +0200 [thread overview]
Message-ID: <Yt6OcTErVYiGYRXq@kroah.com> (raw)
In-Reply-To: <bd13881e-6a78-8831-18a8-5b022e8648ce@nfschina.com>
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Mon, Jul 25, 2022 at 05:54:15PM +0800, tury wrote:
> When there is insufficient memory, the allocation will fail.
And have you ever seen that happen here? The issue is for small
allocations, they never will fail.
> the return value is void,so i think it is ok .
Why?
> should i have changed comment to something like this ?
>
> As the possible alloc failure of the kmalloc() and vmalloc(),
> the return pointer could be NULL.therefore it should be better to check it.
Please wrap your lines properly, and use '.' correctly.
thanks,
greg k-h
next prev parent reply other threads:[~2022-07-25 12:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 8:11 [PATCH 2/3] lkdtm/perms: Check possible NULL pointer returned by kmalloc(),vmalloc() Ren Yu
2022-07-25 8:42 ` Greg KH
2022-07-25 9:54 ` tury
2022-07-25 12:37 ` Greg KH [this message]
2022-07-26 5:43 ` tury
2022-07-27 21:00 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yt6OcTErVYiGYRXq@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=renyu@nfschina.com \
--cc=yuzhe@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox