Re: [PATCH v5] cpu/hotplug: Do not bail-out in DYING/STARTING sections

Thorsten Leemhuis
2022-09-27T10:20:34Z

On 27.09.22 12:05, Vincent Donnefort wrote:
> On Tue, Sep 20, 2022 at 11:59:06AM +0200, Thorsten Leemhuis wrote:
>> On 17.08.22 11:46, Thorsten Leemhuis wrote:
>>>
>>> On 25.07.22 11:59, Vincent Donnefort wrote:
>>>> The DYING/STARTING callbacks are not expected to fail. However, as reported
>>>> by Derek, drivers such as tboot are still free to return errors within
>>>> those sections, which halts the hot(un)plug and leaves the CPU in an
>>>> unrecoverable state.
>>>>
>>>> No rollback being possible there, let's only log the failures and proceed
>>>> with the following steps. This restores the hotplug behaviour prior to
>>>> commit 453e41085183 ("cpu/hotplug: Add cpuhp_invoke_callback_range()")
>>>>
>>>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215867
>>>> Fixes: 453e41085183 ("cpu/hotplug: Add cpuhp_invoke_callback_range()")
>>>> Reported-by: Derek Dolney <z23@posteo.net>
>>>> Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
>>>> Tested-by: Derek Dolney <z23@posteo.net>
>>>
>>> What's the status here? Did that patch to fixing a regression fall
>>> through the cracks? It looks like nothing happened for 3 weeks now,
>>> that's why I wondered, but maybe I missed something.
>>
>> Hmm, Vincent seems to be MIA, at least I see no recent messages from him
>> on lore. Odd. But well, it's still a fix for a regression and it's up to
>> v5 already; Valentin already added his Reviewed-by, too. Would be a
>> shame to waste this.
>>
>> Thomas, could you maybe take a look at the patch? Maybe we're lucky and
>> the patch is already good to go...
>
> AFAIK, this patch is still valid.

Great, thx for confirming!

> I don't think I do have any further action on
> that though.

Well, it seems in this case someone needs to knock on some doors to get
the maintainers to look at this fix to finally get the regression
resolved, as it seems they haven't looked closely at the patch for good
or bad reasons. I hope this mail exchange was enough to get things
rolling again, otherwise we sooner or later we have to get Linus
involved. :-/

Ciao, Thorsten