From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B239CC43334 for ; Thu, 14 Jul 2022 14:12:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240377AbiGNOMq (ORCPT ); Thu, 14 Jul 2022 10:12:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240429AbiGNOM1 (ORCPT ); Thu, 14 Jul 2022 10:12:27 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBDCF5F980; Thu, 14 Jul 2022 07:12:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D09F0CE27C4; Thu, 14 Jul 2022 14:12:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7B9FC34114; Thu, 14 Jul 2022 14:12:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657807935; bh=8fBfjFECA4prmKNVhYJ0IJWUT9G/Hd/flA0UAeza7Ps=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1Sn+Vb2lm4WCBLgAy9MkxbYMFMMXKKx1sWr4qY5ZJcTqUP5Gy13Q/LbCAeV4PyY6C zvADvB4YQxk4A4UCQoAg2Wjd9jVsJ+MFdW1YI2R/7/88hTShda6SqfqsM0YUcIXPbg HgEsIh67KCNLVXxO87wPDP3n5pZdpg/WRTHTmO8s= Date: Thu, 14 Jul 2022 15:49:33 +0200 From: Greg KH To: "Kao, Ben" Cc: "Nyman, Mathias" , "mathias.nyman@linux.intel.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] xhci-pci: Enable runtime PM on Alder Lake-N PCH xHCI controller Message-ID: References: <20220712122442.22504-1-ben.kao@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2022 at 09:06:44AM +0000, Kao, Ben wrote: > > From: Greg KH > > Sent: Tuesday, July 12, 2022 8:45 PM > > To: Kao, Ben > > Cc: Nyman, Mathias ; > > mathias.nyman@linux.intel.com; linux-usb@vger.kernel.org; linux- > > kernel@vger.kernel.org > > Subject: Re: [PATCH] xhci-pci: Enable runtime PM on Alder Lake-N PCH xHCI > > controller > > > > On Tue, Jul 12, 2022 at 08:24:42PM +0800, Ben Kao wrote: > > > There are two Alder Lake-N xHCI host controllers with PCI IDs 0x464e > > > and 0x54ed, now we add the quirk to default enable runtime PM for > > > 0x54ed. > > > > > > Signed-off-by: Ben Kao > > > --- > > > drivers/usb/host/xhci-pci.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c > > > index dce6c0ec8d34..44486156bd5d 100644 > > > --- a/drivers/usb/host/xhci-pci.c > > > +++ b/drivers/usb/host/xhci-pci.c > > > @@ -61,6 +61,7 @@ > > > #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_XHCI 0x461e > > > #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_XHCI > > 0x464e > > > #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_PCH_XHCI 0x51ed > > > +#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_PCH_XHCI 0x54ed > > > > I think we ask this every time, but why don't we enable this for all devices > > and then only disable it for the tiny number that don't need it? > Got it, I will provide another patch to enable runtime PM by default for all > Intel devices if no one has concerns. Please test to verify that it works on the systems you enable it for and verify that future devices will also work properly. thanks, greg k-h