public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: lib/arc4 - expose library interface
Date: Thu, 14 Jul 2022 19:04:34 -0700	[thread overview]
Message-ID: <YtDLMmwffn6p/rSV@sol.localdomain> (raw)
In-Reply-To: <20220714051221.22525-1-ansuelsmth@gmail.com>

On Thu, Jul 14, 2022 at 07:12:21AM +0200, Christian Marangi wrote:
> Permit to compile the arc4 crypto lib without any user. This is required
> by the backports project [1] that require this lib for any wireless
> driver.
> 
> [1] https://backports.wiki.kernel.org/index.php/Main_Page
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
>  lib/crypto/Kconfig | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/crypto/Kconfig b/lib/crypto/Kconfig
> index 2082af43d51f..2dfc785a7817 100644
> --- a/lib/crypto/Kconfig
> +++ b/lib/crypto/Kconfig
> @@ -6,7 +6,11 @@ config CRYPTO_LIB_AES
>  	tristate
>  
>  config CRYPTO_LIB_ARC4
> -	tristate
> +	tristate "ARC4 library interface"
> +	help
> +	  Enable the ARC4 library interface. This interface is mainly
> +	  used by wireless drivers and is required by the backports
> +	  project.
>  
>  config CRYPTO_ARCH_HAVE_LIB_BLAKE2S
>  	bool

I don't think this is appropriate for upstream, as the upstream kernel doesn't
support out-of-tree code.  This is also an internal API that can change from one
kernel version to the next.

- Eric

  reply	other threads:[~2022-07-15  2:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14  5:12 [PATCH] crypto: lib/arc4 - expose library interface Christian Marangi
2022-07-15  2:04 ` Eric Biggers [this message]
2022-07-15  7:39   ` David Laight
2022-07-15  2:10     ` Christian Marangi
2022-07-16  5:49       ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YtDLMmwffn6p/rSV@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=ansuelsmth@gmail.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox