From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61941C433EF for ; Fri, 15 Jul 2022 08:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230370AbiGOIqM (ORCPT ); Fri, 15 Jul 2022 04:46:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229761AbiGOIqI (ORCPT ); Fri, 15 Jul 2022 04:46:08 -0400 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD23C814A8 for ; Fri, 15 Jul 2022 01:46:07 -0700 (PDT) Received: by theia.8bytes.org (Postfix, from userid 1000) id 6F10A535; Fri, 15 Jul 2022 10:46:06 +0200 (CEST) Date: Fri, 15 Jul 2022 10:46:05 +0200 From: Joerg Roedel To: Suravee Suthikulpanit Cc: linux-kernel@vger.kernel.org, iommu@lists.linux.dev, robin.murphy@arm.com, vasant.hegde@amd.com, ashish.kalra@amd.com, jon.grimm@amd.com Subject: Re: [PATCH v4 8/9] iommu/amd: Do not support IOMMU_DOMAIN_IDENTITY after SNP is enabled Message-ID: References: <20220713225651.20758-1-suravee.suthikulpanit@amd.com> <20220713225651.20758-9-suravee.suthikulpanit@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220713225651.20758-9-suravee.suthikulpanit@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 13, 2022 at 05:56:50PM -0500, Suravee Suthikulpanit wrote: > + /* > + * Since DTE[Mode]=0 is prohibited on SNP-enabled system, > + * default to use IOMMU_DOMAIN_DMA[_FQ]. > + */ > + if (WARN_ONCE(amd_iommu_snp_en && (type == IOMMU_DOMAIN_IDENTITY), > + "Cannot allocate identity domain due to SNP\n")) I removed that WARN_ON_ONCE() here, this is really no condition someone should worry about. Regards, Joerg