From: Nicolas Schier <n.schier@avm.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] kbuild: error out if $(KBUILD_EXTMOD) contains % or :
Date: Fri, 15 Jul 2022 11:17:07 +0200 [thread overview]
Message-ID: <YtEwk3dV1Zrx85EZ@buildd.core.avm.de> (raw)
In-Reply-To: <20220714050243.16411-3-masahiroy@kernel.org>
On Thu, Jul 14, 2022 at 02:02:42PM +0900, Masahiro Yamada wrote:
> If the directory pass given to KBUILD_EXTMOD (or M=) contains % or :,
> the module fails to build.
>
> % is used in pattern rules, and : as the separator of dependencies.
>
> Bail out with a clearer error message.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
Reviewed-by: Nicolas Schier <n.schier@avm.de>
next prev parent reply other threads:[~2022-07-15 9:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 5:02 [PATCH 1/4] kbuild: rpm-pkg: fix build error when _arch is undefined Masahiro Yamada
2022-07-14 5:02 ` [PATCH 2/4] kbuild: rpm-pkg: pass 'linux' to --target option of rpmbuild Masahiro Yamada
2022-07-14 5:02 ` [PATCH 3/4] kbuild: error out if $(KBUILD_EXTMOD) contains % or : Masahiro Yamada
2022-07-15 9:17 ` Nicolas Schier [this message]
2022-07-16 15:38 ` Masahiro Yamada
2022-07-14 5:02 ` [PATCH 4/4] kbuild: error out if $(INSTALL_MOD_PATH) " Masahiro Yamada
2022-07-15 9:17 ` Nicolas Schier
2022-07-16 15:40 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtEwk3dV1Zrx85EZ@buildd.core.avm.de \
--to=n.schier@avm.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox