From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD8F4C433EF for ; Fri, 15 Jul 2022 11:48:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232763AbiGOLsr (ORCPT ); Fri, 15 Jul 2022 07:48:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbiGOLsl (ORCPT ); Fri, 15 Jul 2022 07:48:41 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D987639B for ; Fri, 15 Jul 2022 04:48:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 43BADCE2EEE for ; Fri, 15 Jul 2022 11:48:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED09DC34115; Fri, 15 Jul 2022 11:48:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657885716; bh=mKWhPThcZmP1RLWqrhqBF+ZhH0KatTGFVjzBtLtdpu4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eERiyrRXCg7lr+J2REf2VMzZc1HPKXbJtpBbKd+r+lOBbsWRGYbwiN1+jREtEsA3M RSGqId2uDmoYE7OmEa0udZULdp+WAYVYIHTFP3aiNYz9K5TXJgkhUaFKaAdi80WmFN VrJDjMHfKUFYKf1Hw7MjZt5WPmLSlg+XJeLxH9QRO4nx6T98It2tAAilvmf6FVx1f3 CHcdv96gAldK6MS9LUfRSGpkFkyNqxRopxjXPmdrddqs+Cgp4DZYmxN1T7hFMS8hEM trd5cCVZd5XX5+rg8ZsUo93P2lyvkuCwajbIFzu3PnEpC8XXdHrY76jAT6c1nB0KE+ tn6jiZAlXd3+g== Date: Fri, 15 Jul 2022 17:18:32 +0530 From: Vinod Koul To: Samuel Holland Cc: Frank Wunderlich , Greg Kroah-Hartman , Peter Geis , Heiko Stuebner , Kishon Vijay Abraham I , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] phy: rockchip-inno-usb2: Ignore OTG IRQs in host mode Message-ID: References: <20220708061434.38115-1-samuel@sholland.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220708061434.38115-1-samuel@sholland.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08-07-22, 01:14, Samuel Holland wrote: > When the OTG port is fixed to host mode, the driver does not request its > IRQs, nor does it enable those IRQs in hardware. Similarly, the driver > should ignore the OTG port IRQs when handling the shared interrupt. > > Otherwise, it would update the extcon based on an ID pin which may be in > an undefined state, or try to queue a uninitialized work item. Applied, thanks -- ~Vinod