From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E771CC433EF for ; Mon, 18 Jul 2022 05:30:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233314AbiGRFaJ (ORCPT ); Mon, 18 Jul 2022 01:30:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbiGRFaG (ORCPT ); Mon, 18 Jul 2022 01:30:06 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F284E0E8 for ; Sun, 17 Jul 2022 22:30:05 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id r186so9640944pgr.2 for ; Sun, 17 Jul 2022 22:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=v3rPSqyZCvcUyzHN9ra5fCExOPk8KP5mvJg/MF40JO4=; b=pJrkw0w0wfx9IJzlhXxXwjTHqRRFFJMUI1k9FUjgKtHXjoYJZ5EVlh93iN0UFMDAb7 2l8fExGjnXw28RCa7leChjpIYiAEcdvpGmUCfnVrrojy2jvQL9EPWG1D9150C8Ph3zHP b5TFcGASf09a6yvGDyZVgxafYQSeIU+zUiFd/knIxpOlsBIKVvtsdy9nlqcuIDu5+f5d QSAMrOvyJEnDPUygWqj/24XIwfgctGYnGaBVufpa6RYsCl1busFSvi5px9X8pXwXwCVy XwZuTOsNjNevh/Amq5tdWE4Ee6Bzq7MEZVtWxl6SCqUa7bY2N3GYuxWjjMSyNTnsGuZ6 53qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=v3rPSqyZCvcUyzHN9ra5fCExOPk8KP5mvJg/MF40JO4=; b=YLJNhpBHNBDs1vD40Bod3Ehs3pGI2amx4hoH28I+BEesM0cHQFFfNEsdOsw72hM6mm zmyr10CwbiMnAXW3WZg10PmfMBgVH+M7KmpSM0yj6ihoVQdYTVii2bCfeque1Xb4PGob Tx7gkwSmxgZj9W9WJsbscvZ+86ApS4oL9pqtNxjqbPBCpkMeEm8FxpMfOXTrZPW9xfqi zy69SfC78AlQLU7jaGC2TvvMFm8oVJi0D0pF/2FlIBeKsTqQadEYEsb7O4vQpw/YBJNp JMoLFLqMT389eO1R0W8RlSgXkyDPozBC0CWnQKPEaxYHBWRmp598xE9yz+cxWUkjM3YG 5DEQ== X-Gm-Message-State: AJIora94xIMj6blaQN9Ia4uw/99mw8FdEz+iedwaXCoBEpYsaO/3kD1+ fZWbJKjUYetheZ/Yh49+Lv64bw== X-Google-Smtp-Source: AGRyM1smWiOj3KxSI0FjEWFwTm69u4p2Y4DvrX0eOSFM9rIHF23q01Vjf7gO/IR1+rmM+5ODge9lVg== X-Received: by 2002:a63:310c:0:b0:415:368b:fd0a with SMTP id x12-20020a63310c000000b00415368bfd0amr23215021pgx.218.1658122204586; Sun, 17 Jul 2022 22:30:04 -0700 (PDT) Received: from google.com (59.39.145.34.bc.googleusercontent.com. [34.145.39.59]) by smtp.gmail.com with ESMTPSA id z16-20020aa79490000000b0052512fdaa43sm8147472pfk.163.2022.07.17.22.30.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jul 2022 22:30:03 -0700 (PDT) Date: Mon, 18 Jul 2022 05:30:00 +0000 From: Mingwei Zhang To: Sean Christopherson Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] KVM: x86: Apply NX mitigation more precisely Message-ID: References: <20220409003847.819686-1-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220409003847.819686-1-seanjc@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 09, 2022, Sean Christopherson wrote: > This is just the kernel (NX) side of Mingwei's series "Verify dirty > logging works properly with page stats". Relatively to v3 of Mingwei's > series[*], this fixes accounting (and tracking in the nonpaging case) > of disallowed NX huge pages. > > I left off the selftests because I disagree with the "Dump stats" change, > and this has snowballed enough. Hi Sean, Ping on this one? This series might need a rebase and I can quickly provide the review, since several issues are blocked by this. Or if you are busy, I can help driving it. Thanks. -Mingwei > > https://lore.kernel.org/all/20220401063636.2414200-1-mizhang@google.com > > Mingwei Zhang (1): > KVM: x86/mmu: explicitly check nx_hugepage in > disallowed_hugepage_adjust() > > Sean Christopherson (5): > KVM: x86/mmu: Tag disallowed NX huge pages even if they're not tracked > KVM: x86/mmu: Properly account NX huge page workaround for nonpaging > MMUs > KVM: x86/mmu: Set disallowed_nx_huge_page in TDP MMU before setting > SPTE > KVM: x86/mmu: Track the number of TDP MMU pages, but not the actual > pages > KVM: x86/mmu: Add helper to convert SPTE value to its shadow page > > arch/x86/include/asm/kvm_host.h | 17 ++---- > arch/x86/kvm/mmu.h | 9 +++ > arch/x86/kvm/mmu/mmu.c | 104 ++++++++++++++++++++++---------- > arch/x86/kvm/mmu/mmu_internal.h | 33 +++++----- > arch/x86/kvm/mmu/paging_tmpl.h | 6 +- > arch/x86/kvm/mmu/spte.c | 11 ++++ > arch/x86/kvm/mmu/spte.h | 17 ++++++ > arch/x86/kvm/mmu/tdp_mmu.c | 49 +++++++++------ > arch/x86/kvm/mmu/tdp_mmu.h | 2 + > 9 files changed, 167 insertions(+), 81 deletions(-) > > > base-commit: 6521e072010d10380eca3d8a2203990e61e16ae0 > -- > 2.35.1.1178.g4f1659d476-goog >