Re: [PATCH v13 net-next 9/9] mfd: ocelot: add support for the vsc7512 chip via spi

Colin Foster
2022-07-18T16:25:11Z

On Mon, Jul 18, 2022 at 03:18:28PM +0100, Lee Jones wrote:
> On Tue, 05 Jul 2022, Colin Foster wrote:
>
> > The VSC7512 is a networking chip that contains several peripherals. Many of
> > these peripherals are currently supported by the VSC7513 and VSC7514 chips,
> > but those run on an internal CPU. The VSC7512 lacks this CPU, and must be
> > controlled externally.
> >
> > Utilize the existing drivers by referencing the chip as an MFD. Add support
> > for the two MDIO buses, the internal phys, pinctrl, and serial GPIO.
> >
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > ---
> > MAINTAINERS | 1 +
> > drivers/mfd/Kconfig | 21 +++
> > drivers/mfd/Makefile | 3 +
> > drivers/mfd/ocelot-core.c | 169 ++++++++++++++++++++
> > drivers/mfd/ocelot-spi.c | 317 ++++++++++++++++++++++++++++++++++++++
> > drivers/mfd/ocelot.h | 34 ++++
> > 6 files changed, 545 insertions(+)
> > create mode 100644 drivers/mfd/ocelot-core.c
> > create mode 100644 drivers/mfd/ocelot-spi.c
> > create mode 100644 drivers/mfd/ocelot.h
>
> Generally this is looking much better.
>
> Almost ready for inclusion with just a few nits.
>

Hi Lee,

Thanks for the feedback. I'll get these fixes done this week!