Re: [PATCH 28/35] perf intel-pt: Remove guest_machine_pid

Ian Rogers
2022-07-20T01:23:27Z

On Mon, Jul 11, 2022 at 2:33 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> Remove guest_machine_pid because it is not needed.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
> tools/perf/util/intel-pt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c
> index 62b2f375a94d..014f9f73cc49 100644
> --- a/tools/perf/util/intel-pt.c
> +++ b/tools/perf/util/intel-pt.c
> @@ -194,7 +194,6 @@ struct intel_pt_queue {
> struct machine *guest_machine;
> struct thread *guest_thread;
> struct thread *unknown_guest_thread;
> - pid_t guest_machine_pid;
> bool exclude_kernel;
> bool have_sample;
> u64 time;
> @@ -685,7 +684,7 @@ static int intel_pt_get_guest(struct intel_pt_queue *ptq)
> struct machine *machine;
> pid_t pid = ptq->pid <= 0 ? DEFAULT_GUEST_KERNEL_ID : ptq->pid;
>
> - if (ptq->guest_machine && pid == ptq->guest_machine_pid)
> + if (ptq->guest_machine && pid == ptq->guest_machine->pid)
> return 0;
>
> ptq->guest_machine = NULL;
> @@ -705,7 +704,6 @@ static int intel_pt_get_guest(struct intel_pt_queue *ptq)
> return -1;
>
> ptq->guest_machine = machine;
> - ptq->guest_machine_pid = pid;
>
> return 0;
> }
> --
> 2.25.1
>