public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Wen Pu <puwen@hygon.cn>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: retbleed on hygon
Date: Mon, 18 Jul 2022 15:33:30 +0200	[thread overview]
Message-ID: <YtVhKtJkb23CcTtb@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <584296cf-80d7-5c78-8bd0-6eb53a5bc914@hygon.cn>

On Mon, Jul 18, 2022 at 01:03:41PM +0000, Wen Pu wrote:
> On 2022/7/18 19:44, Peter Zijlstra wrote:
> > Hi Pu Wen,
> > 
> > Now that retbleed is public could you please review the patches in
> > question and clarify the situation vs Hygon please? For development I've
> > assumed Hygon is basically Zen1 wrt this issue.
> 
> Hi Peter,
> 
> I'm sorry that there is something wrong with my email these days, so I
> haven't received the patches. Do you mean those with "[peterz: add
> hygon]" added by you? Thanks a lot for taking Hygon into account. I'll
> clarify it as soon as possible.

It's not your email, it was a hardware embargo issue so these patches
have never been mailed out before hitting Linus' tree :-/

Please double check the entire series, see the merge commit:

  ce114c866860 ("Merge tag 'x86_bugs_retbleed' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip")

But in specific pay attention to commits:

  a149180fbcf336e97ce4eb2cdc13672727feb94d
  6b80b59b3555706508008f1f127b5412c89c7fd8
  3ebc170068885b6fc7bedda6c667bb2c4d533159
  d7caac991feeef1b871ee6988fd2c9725df09039
  26aae8ccbc1972233afd08fb3f368947c0314265

Basically everything that has HYGON in it. For that first commit, double
check with your hardware folks the mitigation actually works for Hygon
too. For the other commits validate it DTRT wrt HYGON. Please also send
a patch enabling or removing the spectral chicken for hygon.


  parent reply	other threads:[~2022-07-18 13:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18 11:44 retbleed on hygon Peter Zijlstra
     [not found] ` <584296cf-80d7-5c78-8bd0-6eb53a5bc914@hygon.cn>
2022-07-18 13:33   ` Peter Zijlstra [this message]
     [not found]     ` <1a7c7b91-06d5-5336-279c-6bfacfb209f3@hygon.cn>
2022-07-22 11:34       ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YtVhKtJkb23CcTtb@worktop.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=puwen@hygon.cn \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox