From: Peter Zijlstra <peterz@infradead.org>
To: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
x86@kernel.org, ardb@kernel.org, tglx@linutronix.de,
gregkh@linuxfoundation.org, torvalds@linux-foundation.org,
Guenter Roeck <linux@roeck-us.net>, Borislav Petkov <bp@suse.de>,
Josh Poimboeuf <jpoimboe@kernel.org>,
stable@vger.kernel.org, Andrew Cooper <Andrew.Cooper3@citrix.com>
Subject: Re: [PATCH] efi/x86: use naked RET on mixed mode call wrapper
Date: Mon, 18 Jul 2022 18:10:36 +0200 [thread overview]
Message-ID: <YtWF/GLXxBNQjkOX@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <YtVnNnyDjt2vrWiR@quatroqueijos>
On Mon, Jul 18, 2022 at 10:59:18AM -0300, Thadeu Lima de Souza Cascardo wrote:
> And I think you nailed what I had in mind for using IBPB when doing firmware
> calls, and perhaps this is wanted even when we ignore this naked RET here.
>
> There is a typo on your patch below, but I will give it a try and see if it
> doesn't blow up on AMD systems without IBPB (by way of emulation).
Yeah, Boris pointed out the same. Typing is hard ;-)
next prev parent reply other threads:[~2022-07-18 16:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 19:45 [PATCH] efi/x86: use naked RET on mixed mode call wrapper Thadeu Lima de Souza Cascardo
2022-07-15 22:51 ` Guenter Roeck
2022-07-18 11:41 ` Peter Zijlstra
2022-07-18 13:59 ` Thadeu Lima de Souza Cascardo
2022-07-18 16:10 ` Peter Zijlstra [this message]
2022-07-18 16:28 ` Borislav Petkov
2022-07-18 16:38 ` Peter Zijlstra
2022-07-18 17:19 ` Andrew Cooper
2022-07-18 18:34 ` Linus Torvalds
2022-07-18 18:46 ` Borislav Petkov
2022-07-19 15:22 ` Ard Biesheuvel
2022-07-19 17:37 ` Borislav Petkov
2022-07-19 19:45 ` [tip: x86/urgent] x86/amd: Use IBPB for firmware calls tip-bot2 for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtWF/GLXxBNQjkOX@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Andrew.Cooper3@citrix.com \
--cc=ardb@kernel.org \
--cc=bp@suse.de \
--cc=cascardo@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=jpoimboe@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox