From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jason Wang <wangborong@cdjrlc.com>
Cc: <daniel@ffwll.ch>, <airlied@linux.ie>,
<jani.nikula@linux.intel.com>, <joonas.lahtinen@linux.intel.com>,
<tvrtko.ursulin@linux.intel.com>, <ramalingam.c@intel.com>,
<thomas.hellstrom@linux.intel.com>, <matthew.auld@intel.com>,
<dan.carpenter@oracle.com>, <intel-gfx@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/i915/gt: Remove unneeded semicolon
Date: Mon, 18 Jul 2022 14:29:18 -0400 [thread overview]
Message-ID: <YtWmfuJ9EvnFDh2t@intel.com> (raw)
In-Reply-To: <20220716184439.72056-1-wangborong@cdjrlc.com>
On Sun, Jul 17, 2022 at 02:44:39AM +0800, Jason Wang wrote:
> The semicolon after the `}' in line 648 is unneeded.
same here
The line number changes... if you remove the "in line #"
the msg gets better.
With that changed:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
> index 2c35324b5f68..a69b244f14d0 100644
> --- a/drivers/gpu/drm/i915/gt/intel_migrate.c
> +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
> @@ -645,7 +645,7 @@ static int scatter_list_length(struct scatterlist *sg)
> while (sg && sg_dma_len(sg)) {
> len += sg_dma_len(sg);
> sg = sg_next(sg);
> - };
> + }
>
> return len;
> }
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-07-18 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-16 18:44 [PATCH] drm/i915/gt: Remove unneeded semicolon Jason Wang
2022-07-18 18:29 ` Rodrigo Vivi [this message]
2022-07-21 8:09 ` Rodrigo Vivi
-- strict thread matches above, loose matches on Subject: below --
2022-07-16 4:08 Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtWmfuJ9EvnFDh2t@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.auld@intel.com \
--cc=ramalingam.c@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=wangborong@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox