* [PATCH] drm/i915/gt: Remove unneeded semicolon
@ 2022-07-16 18:44 Jason Wang
2022-07-18 18:29 ` Rodrigo Vivi
2022-07-21 8:09 ` Rodrigo Vivi
0 siblings, 2 replies; 4+ messages in thread
From: Jason Wang @ 2022-07-16 18:44 UTC (permalink / raw)
To: daniel
Cc: airlied, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, ramalingam.c, thomas.hellstrom, matthew.auld,
dan.carpenter, intel-gfx, dri-devel, linux-kernel, Jason Wang
The semicolon after the `}' in line 648 is unneeded.
Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
index 2c35324b5f68..a69b244f14d0 100644
--- a/drivers/gpu/drm/i915/gt/intel_migrate.c
+++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
@@ -645,7 +645,7 @@ static int scatter_list_length(struct scatterlist *sg)
while (sg && sg_dma_len(sg)) {
len += sg_dma_len(sg);
sg = sg_next(sg);
- };
+ }
return len;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915/gt: Remove unneeded semicolon
2022-07-16 18:44 [PATCH] drm/i915/gt: Remove unneeded semicolon Jason Wang
@ 2022-07-18 18:29 ` Rodrigo Vivi
2022-07-21 8:09 ` Rodrigo Vivi
1 sibling, 0 replies; 4+ messages in thread
From: Rodrigo Vivi @ 2022-07-18 18:29 UTC (permalink / raw)
To: Jason Wang
Cc: daniel, airlied, jani.nikula, joonas.lahtinen, tvrtko.ursulin,
ramalingam.c, thomas.hellstrom, matthew.auld, dan.carpenter,
intel-gfx, dri-devel, linux-kernel
On Sun, Jul 17, 2022 at 02:44:39AM +0800, Jason Wang wrote:
> The semicolon after the `}' in line 648 is unneeded.
same here
The line number changes... if you remove the "in line #"
the msg gets better.
With that changed:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
> index 2c35324b5f68..a69b244f14d0 100644
> --- a/drivers/gpu/drm/i915/gt/intel_migrate.c
> +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
> @@ -645,7 +645,7 @@ static int scatter_list_length(struct scatterlist *sg)
> while (sg && sg_dma_len(sg)) {
> len += sg_dma_len(sg);
> sg = sg_next(sg);
> - };
> + }
>
> return len;
> }
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915/gt: Remove unneeded semicolon
2022-07-16 18:44 [PATCH] drm/i915/gt: Remove unneeded semicolon Jason Wang
2022-07-18 18:29 ` Rodrigo Vivi
@ 2022-07-21 8:09 ` Rodrigo Vivi
1 sibling, 0 replies; 4+ messages in thread
From: Rodrigo Vivi @ 2022-07-21 8:09 UTC (permalink / raw)
To: Jason Wang
Cc: daniel, tvrtko.ursulin, dri-devel, thomas.hellstrom, airlied,
intel-gfx, linux-kernel, matthew.auld, dan.carpenter
On Sun, Jul 17, 2022 at 02:44:39AM +0800, Jason Wang wrote:
> The semicolon after the `}' in line 648 is unneeded.
I removed the line mention while pushing to drm-intel-gt-next.
Thanks for the patch.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
> index 2c35324b5f68..a69b244f14d0 100644
> --- a/drivers/gpu/drm/i915/gt/intel_migrate.c
> +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
> @@ -645,7 +645,7 @@ static int scatter_list_length(struct scatterlist *sg)
> while (sg && sg_dma_len(sg)) {
> len += sg_dma_len(sg);
> sg = sg_next(sg);
> - };
> + }
>
> return len;
> }
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/i915/gt: Remove unneeded semicolon
@ 2022-07-16 4:08 Jason Wang
0 siblings, 0 replies; 4+ messages in thread
From: Jason Wang @ 2022-07-16 4:08 UTC (permalink / raw)
To: daniel
Cc: jani.nikula, joonas.lahtinen, rodrigo.vivi, tvrtko.ursulin,
airlied, ramalingam.c, thomas.hellstrom, matthew.auld,
dan.carpenter, intel-gfx, dri-devel, linux-kernel, Jason Wang
The semicolon after a code block end symbol `}' is unneeded, remove
it.
Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
index 2c35324b5f68..a69b244f14d0 100644
--- a/drivers/gpu/drm/i915/gt/intel_migrate.c
+++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
@@ -645,7 +645,7 @@ static int scatter_list_length(struct scatterlist *sg)
while (sg && sg_dma_len(sg)) {
len += sg_dma_len(sg);
sg = sg_next(sg);
- };
+ }
return len;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-21 8:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-16 18:44 [PATCH] drm/i915/gt: Remove unneeded semicolon Jason Wang
2022-07-18 18:29 ` Rodrigo Vivi
2022-07-21 8:09 ` Rodrigo Vivi
-- strict thread matches above, loose matches on Subject: below --
2022-07-16 4:08 Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox