RE: [PATCH v4 11/13] cpufreq: amd_pstate: update transition delay time to 1ms

Yuan, Perry
2022-07-19T06:33:24Z

[AMD Official Use Only - General]

Hi Ray.

> -----Original Message-----
> From: Huang, Ray <Ray.Huang@amd.com>
> Sent: Tuesday, July 19, 2022 9:05 AM
> To: Yuan, Perry <Perry.Yuan@amd.com>
> Cc: rafael.j.wysocki@intel.com; viresh.kumar@linaro.org; Sharma, Deepak
> <Deepak.Sharma@amd.com>; Limonciello, Mario
> <Mario.Limonciello@amd.com>; Fontenot, Nathan
> <Nathan.Fontenot@amd.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Su, Jinzhou (Joe) <Jinzhou.Su@amd.com>;
> Huang, Shimmer <Shimmer.Huang@amd.com>; Du, Xiaojian
> <Xiaojian.Du@amd.com>; Meng, Li (Jassmine) <Li.Meng@amd.com>; linux-
> pm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v4 11/13] cpufreq: amd_pstate: update transition delay
> time to 1ms
>
> On Fri, Jul 15, 2022 at 06:04:30PM +0800, Yuan, Perry wrote:
> > Update transition delay time to 1ms, in the AMD CPU autonomous mode
> > and non-autonomous mode, CPPC firmware will decide frequency at 1ms
> > timescale based on the workload utilization.
> >
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> > Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> > Signed-off-by: Su Jinzhou <Jinzhou.Su@amd.com>
>
> Please squeeze this patch into patch 9. I don't really want to separate the
> transition marco update as two patches.
>
> Thanks,
> Ray

Will update this in V5.
Thanks.

Perry.

>
> > ---
> > drivers/cpufreq/amd-pstate.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/amd-pstate.c
> > b/drivers/cpufreq/amd-pstate.c index 4f8600a36194..d3bc441b3923 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -42,7 +42,7 @@
> > #include "amd-pstate-trace.h"
> >
> > #define AMD_PSTATE_TRANSITION_LATENCY 20000
> > -#define AMD_PSTATE_TRANSITION_DELAY 500
> > +#define AMD_PSTATE_TRANSITION_DELAY 1000
> >
> > /*
> > * TODO: We need more time to fine tune processors with shared memory
> > solution
> > --
> > 2.32.0
> >