From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 035E6CCA479 for ; Mon, 18 Jul 2022 21:34:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235534AbiGRVez (ORCPT ); Mon, 18 Jul 2022 17:34:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235533AbiGRVes (ORCPT ); Mon, 18 Jul 2022 17:34:48 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B04629816; Mon, 18 Jul 2022 14:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4kJIbH62hRR2GU6oL7niOpMGvgJbkAuiAh8TauODeGM=; b=K9gd2aVQ80EFQckNHQ6cK380ZK HVgrEGAtEYMwNDZLuKmmQevAkIDX/Rq1tSG0sLKaWBx7R9CDlGFTrC8APy1nIgyjXqaVFhWJtcVoH 6yNsLCNGec2r3gXm/c96Py1bHyc31J+alclZLvDbvGMZOIHp/5dOuaI3WVWP2F/aGih0poylZ07aS Nzd+bQ7i+rIXOf7cATAI8KFiWUr59wvMA0RfUXCITXgpygi1ngP55PglzHDfN/17HiNwChIFz3w5r 5DXTj4z7OJuhu2uXxWsdvCVMCNu8MBj2/bTERB/1QqMCaS7vQjsJBG8n759a5rH45OzOSkqX0UrRr K9L0Iu0Q==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDYNV-004uET-Nz; Mon, 18 Jul 2022 21:34:10 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id DBCF39802A7; Mon, 18 Jul 2022 23:34:08 +0200 (CEST) Date: Mon, 18 Jul 2022 23:34:08 +0200 From: Peter Zijlstra To: Yury Norov Cc: linux-kernel@vger.kernel.org, Alexander Lobakin , Alexei Starovoitov , Alexey Klimov , Andrew Morton , Andrii Nakryiko , Andy Shevchenko , Ben Segall , Christoph Lameter , Dan Williams , Daniel Borkmann , Daniel Bristot de Oliveira , Dennis Zhou , Dietmar Eggemann , Eric Dumazet , Frederic Weisbecker , Guenter Roeck , Ingo Molnar , Isabella Basso , John Fastabend , Josh Poimboeuf , Juergen Gross , Juri Lelli , KP Singh , Kees Cook , Martin KaFai Lau , Mel Gorman , Miroslav Benes , Nathan Chancellor , "Paul E . McKenney" , Randy Dunlap , Rasmus Villemoes , Sebastian Andrzej Siewior , Song Liu , Steven Rostedt , Tejun Heo , Thomas Gleixner , Valentin Schneider , Vincent Guittot , Vlastimil Babka , Yonghong Song , linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 10/16] sched: optimize __set_cpus_allowed_ptr_locked() Message-ID: References: <20220718192844.1805158-1-yury.norov@gmail.com> <20220718192844.1805158-11-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220718192844.1805158-11-yury.norov@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 18, 2022 at 12:28:38PM -0700, Yury Norov wrote: > --- > kernel/sched/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index da0bf6fe9ecd..d6424336ef2d 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -2874,7 +2874,8 @@ static int __set_cpus_allowed_ptr_locked(struct task_struct *p, > cpu_valid_mask = cpu_online_mask; > } > > - if (!kthread && !cpumask_subset(new_mask, cpu_allowed_mask)) { > + if (!kthread && new_mask != cpu_allowed_mask && > + !cpumask_subset(new_mask, cpu_allowed_mask)) { Optimize cpumask_subset() for src1p == src2p instead? > ret = -EINVAL; > goto out; > } > -- > 2.34.1 >