From: Sean Christopherson <seanjc@google.com>
To: Kechen Lu <kechenl@nvidia.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, chao.gao@intel.com,
vkuznets@redhat.com, somduttar@nvidia.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v4 6/7] KVM: x86: Add a new guest_debug flag forcing exit to userspace
Date: Wed, 20 Jul 2022 17:06:07 +0000 [thread overview]
Message-ID: <Ytg1/zdSPYQ2lYS/@google.com> (raw)
In-Reply-To: <20220622004924.155191-7-kechenl@nvidia.com>
On Tue, Jun 21, 2022, Kechen Lu wrote:
> For debug and test purposes, there are needs to explicitly make
> instruction triggered exits could be trapped to userspace. Simply
> add a new flag for guest_debug interface could achieve this.
>
> This patch also fills the userspace accessible field
> vcpu->run->hw.hardware_exit_reason for userspace to determine the
> original triggered VM-exits.
This patch belongs in a different series, AFAICT there are no dependencies between
this and allowing per-vCPU disabling of exits. Allowing userspace to exit on
"every" instruction exit is going to be much more controversial, largely because
it will be difficult for KVM to provide a consistent, robust ABI. E.g. should
KVM exit to userspace if an intercepted instruction is encountered by the emualtor?
TL;DR: drop this patch from the next version.
next prev parent reply other threads:[~2022-07-20 17:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 0:49 [RFC PATCH v4 0/7] KVM: x86: add per-vCPU exits disable capability Kechen Lu
2022-06-22 0:49 ` [RFC PATCH v4 1/7] KVM: x86: only allow exits disable before vCPUs created Kechen Lu
2022-06-22 0:49 ` [RFC PATCH v4 2/7] KVM: x86: Move *_in_guest power management flags to vCPU scope Kechen Lu
2022-06-22 0:49 ` [RFC PATCH v4 3/7] KVM: x86: Reject disabling of MWAIT interception when not allowed Kechen Lu
2022-07-20 17:53 ` Sean Christopherson
2022-07-20 18:37 ` Kechen Lu
2022-06-22 0:49 ` [RFC PATCH v4 4/7] KVM: x86: Let userspace re-enable previously disabled exits Kechen Lu
2022-06-22 0:49 ` [RFC PATCH v4 5/7] KVM: x86: add vCPU scoped toggling for " Kechen Lu
2022-07-20 18:41 ` Sean Christopherson
2022-07-20 19:04 ` Kechen Lu
2022-07-20 19:30 ` Sean Christopherson
2022-07-20 20:23 ` Kechen Lu
2022-06-22 0:49 ` [RFC PATCH v4 6/7] KVM: x86: Add a new guest_debug flag forcing exit to userspace Kechen Lu
2022-07-20 17:06 ` Sean Christopherson [this message]
2022-07-20 19:11 ` Kechen Lu
2022-06-22 0:49 ` [RFC PATCH v4 7/7] KVM: selftests: Add tests for VM and vCPU cap KVM_CAP_X86_DISABLE_EXITS Kechen Lu
2022-06-22 6:44 ` Huang, Shaoqin
2022-06-22 23:30 ` Kechen Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ytg1/zdSPYQ2lYS/@google.com \
--to=seanjc@google.com \
--cc=chao.gao@intel.com \
--cc=kechenl@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=somduttar@nvidia.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox