Re: [PATCH v2 03/11] KVM: x86: emulator: remove assign_eip_near/far

Maxim Levitsky
2022-07-21T11:52:49Z

On Wed, 2022-07-20 at 23:51 +0000, Sean Christopherson wrote:
> On Tue, Jun 21, 2022, Maxim Levitsky wrote:
> > Now the assign_eip_far just updates the emulation mode in addition to
> > updating the rip, it doesn't make sense to keep that function.
> >
> > Move mode update to the callers and remove these functions.
>
> I disagree, IMO there's a lot of value in differentiating between near and far.
> Yeah, the assign_eip_near() wrapper is kinda silly, but have that instead of
> a bare assign_eip() documents that e.g. jmp_rel() is a near jump and that it's
> not missing an update.
>

OK, I'll drop this patch then.

Best regards,
Maxim Levitsky