From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A74D0C433EF for ; Thu, 21 Jul 2022 00:40:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230154AbiGUAkw (ORCPT ); Wed, 20 Jul 2022 20:40:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229906AbiGUAku (ORCPT ); Wed, 20 Jul 2022 20:40:50 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3E89422C2 for ; Wed, 20 Jul 2022 17:40:48 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id d7-20020a17090a564700b001f209736b89so3699400pji.0 for ; Wed, 20 Jul 2022 17:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KH9fFq73YQqYjsyxO6D0porLgzRsQltbJ34jnP4zXh4=; b=iz0p9LKdQrmSzQP8AJxjJmN5xTZMXPJIEDuiBSaEGGcfBu5jQnyU9Y3SlAs4Tcts5z b8vgoydsX+KvP9162K7c8oMq08HrTAw8utpXVekIOdbu0T/8SpFijkrCDU4duZARtohG KYc+N3uq6eDBWFIoWWyhIg96+pwBa9ttxrTYKMwimLT8Y3MJhqh7lcPOYCQoQWQmArrp rjr4+76QmCH5Ip98Ac6YBIynpYgoGe768jB8IMHF5N6fwtOKwQs6Mo1WZ6ysI4U+FNDK GALqiXlnSGzpldLgKa0Vq/uNpx2xPKaYpA+ER/K8Dn6a8Wi9sWGEII0XNb22552nGUQg X0Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KH9fFq73YQqYjsyxO6D0porLgzRsQltbJ34jnP4zXh4=; b=FvhyeVwVe9JkqLWcez9CVY8l5wXiRyhbJyQj9eJb7889KUEJn28dTCwe1ekF0jr3OB +ksBywJpA1wRgHmG9NAMTcha9a0Opc75wkcEeaXwi/oKbw5md1qwXmQIgewAOSU46Smz RIq0TmCOpmXqhFyHPdW2cmgv4KiJ2Aebe8zadp8hl2cO3qYDf9v7UAjDPA8OBhDxAMHS fFUzP0l1Dbej8FX/HYcmdiShE0n2hzbN8U7uN4xVJHsHgU+9sj/oUNCxsK6JX+IX928n H7LoYDAz72zGf9FM2oAh6/0Xls8Jes0UrSuie4shUheqjpwY1A/hb+a3xX/Wr3Is3gUN Z/sA== X-Gm-Message-State: AJIora8HLPzXR61Igg93U67jwAc4QdM/7y2W16ScLxDQT/RQG5lazLAy 7t62IbYb3n0mJ8qNJ2wdnEY7QQ== X-Google-Smtp-Source: AGRyM1umqan83UN80lOz+jt46sai3tfTEzFIsGmDof83tydt4zEPllCUXAFqQDQt7Q8Fo+UUvVe83Q== X-Received: by 2002:a17:90b:4b0a:b0:1f0:5c2d:fe72 with SMTP id lx10-20020a17090b4b0a00b001f05c2dfe72mr8524569pjb.150.1658364048295; Wed, 20 Jul 2022 17:40:48 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id r5-20020a635145000000b0040dd052ab11sm96429pgl.58.2022.07.20.17.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 17:40:47 -0700 (PDT) Date: Thu, 21 Jul 2022 00:40:44 +0000 From: Sean Christopherson To: Maxim Levitsky Cc: kvm@vger.kernel.org, x86@kernel.org, Kees Cook , Dave Hansen , linux-kernel@vger.kernel.org, "H. Peter Anvin" , Borislav Petkov , Joerg Roedel , Ingo Molnar , Paolo Bonzini , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson Subject: Re: [PATCH v2 07/11] KVM: x86: emulator/smm: add structs for KVM's smram layout Message-ID: References: <20220621150902.46126-1-mlevitsk@redhat.com> <20220621150902.46126-8-mlevitsk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220621150902.46126-8-mlevitsk@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2022, Maxim Levitsky wrote: > Those structs will be used to read/write the smram state image. > > Also document the differences between KVM's SMRAM layout and SMRAM > layout that is used by real Intel/AMD cpus. > > Signed-off-by: Maxim Levitsky > --- > arch/x86/kvm/kvm_emulate.h | 139 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 139 insertions(+) > > diff --git a/arch/x86/kvm/kvm_emulate.h b/arch/x86/kvm/kvm_emulate.h > index 89246446d6aa9d..7015728da36d5f 100644 > --- a/arch/x86/kvm/kvm_emulate.h > +++ b/arch/x86/kvm/kvm_emulate.h > @@ -503,6 +503,145 @@ enum x86_intercept { > nr_x86_intercepts > }; > > + > +/* > + * 32 bit KVM's emulated SMM layout > + * Loosely based on Intel's layout > + */ > + > +struct kvm_smm_seg_state_32 { > + u32 flags; > + u32 limit; > + u32 base; > +} __packed; > + > +struct kvm_smram_state_32 { > + > + u32 reserved1[62]; /* FE00 - FEF7 */ > + u32 smbase; /* FEF8 */ > + u32 smm_revision; /* FEFC */ > + u32 reserved2[5]; /* FF00-FF13 */ > + /* CR4 is not present in Intel/AMD SMRAM image*/ > + u32 cr4; /* FF14 */ > + u32 reserved3[5]; /* FF18 */ Again, I love this approach, but we should have compile-time asserts to verify the layout, e.g. see vmx_check_vmcs12_offsets().