From: Leon Romanovsky <leon@kernel.org>
To: Cheng Xu <chengyou@linux.alibaba.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Jason Gunthorpe <jgg@ziepe.ca>,
Kai Shen <kaishen@linux.alibaba.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH 1/2] RDMA/erdma: Use the bitmap API to allocate bitmaps
Date: Thu, 21 Jul 2022 10:31:46 +0300 [thread overview]
Message-ID: <YtkA4tBhlSHX76JM@unreal> (raw)
In-Reply-To: <5bcd437f-92a4-1c04-796c-41559dd2823a@linux.alibaba.com>
On Wed, Jul 20, 2022 at 09:58:24AM +0800, Cheng Xu wrote:
>
>
> On 7/19/22 11:36 PM, Christophe JAILLET wrote:
> > Le 19/07/2022 à 15:01, Dan Carpenter a écrit :
> >> On Tue, Jul 19, 2022 at 09:54:34AM -0300, Jason Gunthorpe wrote:
> >>> On Tue, Jul 12, 2022 at 12:01:10PM +0300, Dan Carpenter wrote:
> >>>
> >>>> Best not to use any auto-formatting tools. They are all bad.
> >>>
> >>> Have you tried clang-format? I wouldn't call it bad..
> >>
> >> I prefered Christophe's formatting to clang's. ;)
> >>
> >> regards,
> >> dan carpenter
> >>
> >>
> >
> > Hi,
> >
> > (some other files in the same directory also have some checkpatch warning/error)
>
> I just double checked the checkpatch results, Two type warnings reported:
>
> - WARNING: Missing commit description - Add an appropriate one (for patch 0001)
> - WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? (for almost all patches except 0001/0011)
>
> For the first warning, the change is very simple: add erdma's
> rdma_driver_id definition, I think the commit title can describe
> all things, and is enough.
To be clear, our preference is to have commit message in any case, even
for simple changes.
Thanks
next prev parent reply other threads:[~2022-07-21 7:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 17:37 [PATCH 1/2] RDMA/erdma: Use the bitmap API to allocate bitmaps Christophe JAILLET
2022-07-08 17:37 ` [PATCH 2/2] RDMA/erdma: Use the non-atomic bitmap API when applicable Christophe JAILLET
2022-07-11 7:34 ` [PATCH 1/2] RDMA/erdma: Use the bitmap API to allocate bitmaps Cheng Xu
2022-07-12 9:01 ` Dan Carpenter
2022-07-12 9:56 ` Cheng Xu
2022-07-19 12:54 ` Jason Gunthorpe
2022-07-19 13:01 ` Dan Carpenter
2022-07-19 15:36 ` Christophe JAILLET
2022-07-19 15:39 ` Jason Gunthorpe
2022-07-20 1:58 ` Cheng Xu
2022-07-21 7:31 ` Leon Romanovsky [this message]
2022-07-21 9:14 ` Cheng Xu
2022-07-21 7:27 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtkA4tBhlSHX76JM@unreal \
--to=leon@kernel.org \
--cc=chengyou@linux.alibaba.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dan.carpenter@oracle.com \
--cc=jgg@ziepe.ca \
--cc=kaishen@linux.alibaba.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox