Re: [PATCH 1/2] RDMA/erdma: Use the bitmap API to allocate bitmaps

Christophe JAILLET
2022-07-19T15:36:48Z

Le 19/07/2022 à 15:01, Dan Carpenter a écrit :
> On Tue, Jul 19, 2022 at 09:54:34AM -0300, Jason Gunthorpe wrote:
>> On Tue, Jul 12, 2022 at 12:01:10PM +0300, Dan Carpenter wrote:
>>
>>> Best not to use any auto-formatting tools. They are all bad.
>>
>> Have you tried clang-format? I wouldn't call it bad..
>
> I prefered Christophe's formatting to clang's. ;)
>
> regards,
> dan carpenter
>
>

Hi,

checkpatch.pl only gives hints and should not blindly be taken as THE
reference, but:

./scripts/checkpatch.pl -f --strict
drivers/infiniband/hw/erdma/erdma_cmdq.c

gives:
CHECK: Lines should not end with a '('
#81: FILE: drivers/infiniband/hw/erdma/erdma_cmdq.c:81:
+ cmdq->comp_wait_bitmap = devm_bitmap_zalloc(

total: 0 errors, 0 warnings, 1 checks, 493 lines checked

(some other files in the same directory also have some checkpatch
warning/error)

Don't know if it may be an issue for maintainers.

CJ