From: Christoph Hellwig <hch@infradead.org>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kallsyms: make arch_get_kallsym() static
Date: Thu, 21 Jul 2022 08:22:39 -0700 [thread overview]
Message-ID: <YtlvP1toPTmv4brF@infradead.org> (raw)
In-Reply-To: <20220721151040.359389-1-ben-linux@fluff.org>
On Thu, Jul 21, 2022 at 04:10:40PM +0100, Ben Dooks wrote:
> The arch_get_kallsym() function is not used anywhere in the kernel
> now, so it should at-least be static or just be removed as there
> are no users. Making it static fixes the following sparse warning:
>
> kernel/kallsyms.c:590:12: warning: symbol 'arch_get_kallsym' was not declared. Should it be static?
It fixes the warning, but isn't exactly useful. Please just remove it,
get_ksymbol_arch and iter->pos_arch_end entirely instead.
next prev parent reply other threads:[~2022-07-21 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 15:10 [PATCH] kallsyms: make arch_get_kallsym() static Ben Dooks
2022-07-21 15:22 ` Christoph Hellwig [this message]
2022-07-22 8:01 ` Ben Dooks
-- strict thread matches above, loose matches on Subject: below --
2021-02-25 7:08 [PATCH] kallsyms: make arch_get_kallsym static Jiapeng Chong
2021-02-25 10:20 ` kernel test robot
2021-02-25 16:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtlvP1toPTmv4brF@infradead.org \
--to=hch@infradead.org \
--cc=ben-linux@fluff.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox