Re: [PATCH 3/5] hugetlbfs: remove unneeded header file

Miaohe Lin
2022-07-22T06:13:04Z

On 2022/7/22 7:18, Mike Kravetz wrote:
> On 07/21/22 21:16, Miaohe Lin wrote:
>> The header file signal.h is unneeded now. Remove it.
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>> ---
>> fs/hugetlbfs/inode.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
>> index a10156df5726..aa7a5b8fc724 100644
>> --- a/fs/hugetlbfs/inode.c
>> +++ b/fs/hugetlbfs/inode.c
>> @@ -11,7 +11,6 @@
>>
>> #include <linux/thread_info.h>
>> #include <asm/current.h>
>> -#include <linux/sched/signal.h> /* remove ASAP */
>
> I see the original '#include <linux/sched.h>' with this 'remove ASAP' comment
> has been there since the initial git repository build. No idea why it was
> originally added, and can find no reason for it to be there today.

Me too. This might be a historical vestige.

>
> Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

Many thank for your reviewing.

>