From: "Darrick J. Wong" <djwong@kernel.org>
To: Oliver Sang <oliver.sang@intel.com>
Cc: Dave Chinner <david@fromorbit.com>,
LKML <linux-kernel@vger.kernel.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, lkp@lists.01.org, lkp@intel.com,
ying.huang@intel.com, feng.tang@intel.com,
zhengjun.xing@linux.intel.com, fengwei.yin@intel.com
Subject: Re: [xfs] 345a4666a7: vm-scalability.throughput -91.7% regression
Date: Thu, 21 Jul 2022 19:21:39 -0700 [thread overview]
Message-ID: <YtoJs8mv7vle8Mhh@magnolia> (raw)
In-Reply-To: <YtoG+kcaC8yfMEZW@xsang-OptiPlex-9020>
On Fri, Jul 22, 2022 at 10:10:02AM +0800, Oliver Sang wrote:
> Hi Darrick, Hi Dave, and all,
>
> sorry for this report is annoying according to Darrick and Dave's comments
> below.
> we will investigate this case and refine our report process.
FWIW, you can still send /me/ reports about the xfs development patches
I post to djwong/xfs-linux.git, but it's not necessary to cc linux-xfs
with that, since most of those patches are still under development
and/or working their way through patch review.
--D
>
> On Thu, Jul 21, 2022 at 02:38:51PM -0700, Darrick J. Wong wrote:
> > On Fri, Jul 22, 2022 at 07:33:37AM +1000, Dave Chinner wrote:
> > > On Thu, Jul 21, 2022 at 11:08:38PM +0800, kernel test robot wrote:
> > > >
> > > > (just FYI for the possible performance impact of disabling large folios,
> > > > our config, as attached, set default N to XFS_LARGE_FOLIOS)
> > > >
> > > >
> > > > Greeting,
> > > >
> > > > FYI, we noticed a -91.7% regression of vm-scalability.throughput due to commit:
> > > >
> > > >
> > > > commit: 345a4666a721a81c343186768cdd95817767195f ("xfs: disable large folios except for developers")
> > >
> > > Say what? I've never seen that change go past on a public list...
> > >
> > > > https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git xfs-5.20-merge
> > >
> > > Oh, it's in a developer's working tree, not something that has been
> > > proposed for review let alone been merged.
> >
> > Correct, djwong-dev has a patch so that I can disable multipage folios
> > so that I could get other QA work done while willy and I try to sort out
> > the generic/522 corruption problems.
> >
> > > So why is this report being sent to lkml, linux-xfs, etc as if it
> > > was a change merged into an upstream tree rather than just the
> > > developer who owns the tree the commit is in?
> >
> > I was wondering that myself.
> >
> > --D
> >
> > > -Dave.
> > > --
> > > Dave Chinner
> > > david@fromorbit.com
prev parent reply other threads:[~2022-07-22 2:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 15:08 [xfs] 345a4666a7: vm-scalability.throughput -91.7% regression kernel test robot
2022-07-21 21:33 ` Dave Chinner
2022-07-21 21:38 ` Darrick J. Wong
2022-07-22 2:10 ` Oliver Sang
2022-07-22 2:21 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtoJs8mv7vle8Mhh@magnolia \
--to=djwong@kernel.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=feng.tang@intel.com \
--cc=fengwei.yin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=oliver.sang@intel.com \
--cc=ying.huang@intel.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox