From: Joerg Roedel <joro@8bytes.org>
To: Jerry Snitselaar <jsnitsel@redhat.com>
Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Will Deacon <will@kernel.org>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/amd: Disable guest vapic logging during early kdump init
Date: Fri, 22 Jul 2022 16:37:13 +0200 [thread overview]
Message-ID: <Ytq2GRX7UJjvXk4w@8bytes.org> (raw)
In-Reply-To: <20220721003439.403435-1-jsnitsel@redhat.com>
On Wed, Jul 20, 2022 at 05:34:39PM -0700, Jerry Snitselaar wrote:
> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> index 1d08f87e734b..2b00d7f28df7 100644
> --- a/drivers/iommu/amd/init.c
> +++ b/drivers/iommu/amd/init.c
> @@ -815,6 +815,11 @@ static void free_ga_log(struct amd_iommu *iommu)
> #endif
> }
>
> +static void iommu_ga_log_disable(struct amd_iommu *iommu)
> +{
> + iommu_feature_disable(iommu, CONTROL_GALOG_EN);
> +}
> +
> static int iommu_ga_log_enable(struct amd_iommu *iommu)
> {
> #ifdef CONFIG_IRQ_REMAP
> @@ -2504,6 +2509,7 @@ static void early_enable_iommus(void)
> for_each_iommu(iommu) {
> iommu_disable_command_buffer(iommu);
> iommu_disable_event_buffer(iommu);
> + iommu_ga_log_disable(iommu);
> iommu_enable_command_buffer(iommu);
> iommu_enable_event_buffer(iommu);
> iommu_enable_ga(iommu);
Looks about right, but I also let Suravee comment on this.
Disabling the GA-Log under a device still using it should hopefully not
put it into some undefined state.
next prev parent reply other threads:[~2022-07-22 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 0:34 [PATCH] iommu/amd: Disable guest vapic logging during early kdump init Jerry Snitselaar
2022-07-22 14:37 ` Joerg Roedel [this message]
2022-07-23 16:33 ` Jerry Snitselaar
2022-07-25 7:05 ` Suravee Suthikulpanit
2022-07-26 7:12 ` Joerg Roedel
2022-07-26 14:00 ` Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ytq2GRX7UJjvXk4w@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux.dev \
--cc=jsnitsel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox