From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21363C433EF for ; Fri, 22 Jul 2022 10:48:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234844AbiGVKsm (ORCPT ); Fri, 22 Jul 2022 06:48:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231902AbiGVKsl (ORCPT ); Fri, 22 Jul 2022 06:48:41 -0400 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A962A6F8F for ; Fri, 22 Jul 2022 03:48:36 -0700 (PDT) Date: Fri, 22 Jul 2022 11:48:31 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1658486914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0AyQqMWkq3QK3cl0AVPhmS1VRFhKVJORRDR1qEdQa2E=; b=xicOKB6Owxf662WLaEHk73CJEtDiVVJlzZYlCwcm2/Diwz0HTpzvGaebKIShQmRpj0iZR1 G0JoITMh43Aju/9To6bjbUkmSVnwtTN0+CxPKbszZa19YuGHmQBj+QkAqOzApPVL6H6VZH n38wfKDStIPrL8+wxF39Kgji85DhFrU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Kalesh Singh Cc: maz@kernel.org, mark.rutland@arm.com, broonie@kernel.org, madvenka@linux.microsoft.com, tabba@google.com, will@kernel.org, qperret@google.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, andreyknvl@gmail.com, vincenzo.frascino@arm.com, mhiramat@kernel.org, ast@kernel.org, drjones@redhat.com, wangkefeng.wang@huawei.com, elver@google.com, keirf@google.com, yuzenghui@huawei.com, ardb@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, android-mm@google.com, kernel-team@android.com Subject: Re: [PATCH v5 00/17] KVM nVHE Hypervisor stack unwinder Message-ID: References: <20220721055728.718573-1-kaleshsingh@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220721055728.718573-1-kaleshsingh@google.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kalesh, On Wed, Jul 20, 2022 at 10:57:11PM -0700, Kalesh Singh wrote: [...] > Kalesh Singh (17): > arm64: stacktrace: Add shared header for common stack unwinding code > arm64: stacktrace: Factor out on_accessible_stack_common() > arm64: stacktrace: Factor out unwind_next_common() > arm64: stacktrace: Handle frame pointer from different address spaces > arm64: stacktrace: Factor out common unwind() > arm64: stacktrace: Add description of stacktrace/common.h > KVM: arm64: On stack overflow switch to hyp overflow_stack > KVM: arm64: Add PROTECTED_NVHE_STACKTRACE Kconfig > KVM: arm64: Allocate shared pKVM hyp stacktrace buffers > KVM: arm64: Stub implementation of pKVM HYP stack unwinder > KVM: arm64: Stub implementation of non-protected nVHE HYP stack > unwinder > KVM: arm64: Save protected-nVHE (pKVM) hyp stacktrace > KVM: arm64: Prepare non-protected nVHE hypervisor stacktrace > KVM: arm64: Implement protected nVHE hyp stack unwinder > KVM: arm64: Implement non-protected nVHE hyp stack unwinder > KVM: arm64: Introduce pkvm_dump_backtrace() > KVM: arm64: Introduce hyp_dump_backtrace() Adding a general comment on the organization of the series. I think for the next spin it'd be good to organize the entire non-pKVM implementation first, followed by the pKVM implementation. Otherwise, reviewers need to jump around the series a lot in order to page in the appropriate context. I had mentioned this about the last two patches earlier, but after grokking the stack I see the comment applies to the entire KVM portion of the series. -- Thanks, Oliver