From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83B09C25B07 for ; Fri, 5 Aug 2022 16:33:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238709AbiHEQdB (ORCPT ); Fri, 5 Aug 2022 12:33:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237623AbiHEQc5 (ORCPT ); Fri, 5 Aug 2022 12:32:57 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A792DF20 for ; Fri, 5 Aug 2022 09:32:57 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id t2so3091935ply.2 for ; Fri, 05 Aug 2022 09:32:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=uNgIMraGQEvJv9IeiG/R7BNNwOlVOtJOj1OBE03AYVc=; b=IMDsjfU19RQWCKZgtvsrA4L1JSG2IHZwW/p00vXlnMhJ9uJbqkXAh47oo+H8I709mF 7esbABe7yH96jMFRabePARNdoJg1ikr5Bdd9mXtja3aaQ3MwSiZOvtCGHUJO5i0AXwka gtFV3uo5QaPeiNcLpcaqkkfeRwGozCOTvKyViQ9LXmV6yNLNlO3lWr2takPdFveyA/L4 UWl7bnuhF7ogFsroOh3O01FxaF9FZOFbbof4p7jpbprGY+iBAU3xcA2LhrpkquCSFwTf oUwVzq3ywVt1qaKdzW6tMyNAqqgH9XefcJpi3+Y5YUwDZTgJSbxnjtgDfE1poI3KflwQ HwQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=uNgIMraGQEvJv9IeiG/R7BNNwOlVOtJOj1OBE03AYVc=; b=XcbkvUcmIYLJJfd/0+aNbRyiAmsiPO61Q24/SGceXYc3c2oJiJEBx9c+WZ/bbNkAf3 IvGmlji3KUqThKI8c+glAJg5yLkFpR3nTx5rWtqUXf4XhrP6B5nIxM/Usw5UWKr8UKIu 8p1uFD6P+sawCnpJm221HDinN4783NvYyllPcyTqYplYfNj0VfVLBSe5p0zWMjCIUECt HdT0pome55M06qgEwrx/W2JqmQYFsxeNHPVcJQfnShMgWEPfsDM+WtoKkYnA6MN7a5rj InrrXbYx6psq2qv5OqvvFmFwaNOLiARLgGpvBbCbStzPfBSHhmz+s7RFyALlWc/hLnDu /pqw== X-Gm-Message-State: ACgBeo2jXL8aRcpCSsRn2u0iKXXX5JAwfH33VXWhTI9WYCZWQs4OZdlf eXSyR3q33tlT8AQq5a0iiX978BFx36UdZw== X-Google-Smtp-Source: AA6agR6U/hjD0gicqlU8MA3bvqOWWiO96pQCKsrWlUptyhWQdL3nxYqi8RqEH4sQQGUazQM5B2m61w== X-Received: by 2002:a17:90b:1b07:b0:1f5:115c:79a4 with SMTP id nu7-20020a17090b1b0700b001f5115c79a4mr8458855pjb.166.1659717176367; Fri, 05 Aug 2022 09:32:56 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id a205-20020a621ad6000000b005289fbef7c4sm3341986pfa.140.2022.08.05.09.32.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 09:32:55 -0700 (PDT) Date: Fri, 5 Aug 2022 16:32:52 +0000 From: Sean Christopherson To: Like Xu Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] KVM: selftests: Test writing PERF_CAPABILITIES after KVM_RUN is rejected Message-ID: References: <20220805083744.78767-1-likexu@tencent.com> <20220805083744.78767-3-likexu@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220805083744.78767-3-likexu@tencent.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 05, 2022, Like Xu wrote: > From: Like Xu > > KVM should also disallow changing the feature MSR PERF_CAPABILITIES after > KVM_RUN to prevent unexpected behavior. Implement run_vcpu() in a separate > thread approach and opportunistically rearrange test cases. > > Signed-off-by: Like Xu > --- > .../selftests/kvm/x86_64/vmx_pmu_caps_test.c | 49 +++++++++++++------ Rather than add a one-off PERF_CAPABILITIES test, I would rather we rename and extend get_msr_index_features, e.g. call it feature_msrs_test and then have it test all feature MSRs.