From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DBB9C19F2D for ; Sat, 6 Aug 2022 18:15:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231597AbiHFSP1 (ORCPT ); Sat, 6 Aug 2022 14:15:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231272AbiHFSPV (ORCPT ); Sat, 6 Aug 2022 14:15:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 380935F63; Sat, 6 Aug 2022 11:15:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BDF7D6120D; Sat, 6 Aug 2022 18:15:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCA87C433C1; Sat, 6 Aug 2022 18:15:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659809719; bh=BY4p8tvAesSfXHOIklqi1YqTC0LMDLSpqbPlDu6FZHw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gFgMuRn+fh47VY2tmn9To+ifXShkp4IqH6Nr90jbeljoYgvrAeWY5UraRRdkghz+e xzm5L6LV2uQ0Zt6Tfstd436otgB9fsOpzavtO6V11LJPx8QZjr6yiIwvXe7IfDgPLO Hm12d0O2aiv1wK1rCumewu8MU7C7xVVDFRvHFkSPKnYJ0ztW9ayobWb4ThngMMUsG/ FFmeO0/syPaUu4/1siEHvZuCfZgPvlXtCQIIEUEyD6Tcqf/s3lHkeu1PDZS+9H7KsS rZn35vZ1g0y/ErJ7F4HA0CHSe42T168NrIai9tBMkxQZSLP6mUegUdi0WiK0UArnMj qpovbcbGeADVw== Date: Sat, 6 Aug 2022 21:15:16 +0300 From: Jarkko Sakkinen To: Harald Hoyer Cc: Tom Lendacky , Paolo Bonzini , Jarkko Sakkinen , Brijesh Singh , John Allen , Herbert Xu , "David S. Miller" , "open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER - SE..." , open list Subject: Re: [PATCH] crypto: ccp: Load the firmware twice when SEV API version < 1.43 Message-ID: References: <20220804010223.3619-1-jarkko@kernel.org> <58e8f9dc-a8d3-a2a5-2dd7-0783355e2567@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 04, 2022 at 03:37:20PM +0200, Harald Hoyer wrote: > Am 04.08.22 um 15:13 schrieb Tom Lendacky: > > On 8/3/22 20:02, Jarkko Sakkinen wrote: > > > From: Jarkko Sakkinen > > > > > > SEV-SNP does not initialize to a legit state, unless the firmware is > > > loaded twice, when SEP API version < 1.43, and the firmware is updated > > > to a later version. Because of this user space needs to work around > > > this with "rmmod && modprobe" combo. Fix this by implementing the > > > workaround to the driver. > > > > The SNP hypervisor patches are placing a minimum supported version > > requirement for the SEV firmware that exceeds the specified version > > above [1] (for the reason above, as well as some others), so this patch > > is not needed, NAK. > > As described in the "Milan Release Notes.txt" of the AMD firmware update package amd_sev_fam19h_model0xh_1.33.03.zip. > > "If upgrading to 1.33.01 or later from something older (picking up > CSF-1201), it is required that two Download Firmware commands be run to fix > the "Committed Version" across the firmware. CSF-1201 fixed a bug where the > committed version in the attestation report was incorrect. Performing a > single Download Firmware will upgrade the firmware, but performing a second > one will correct the committed version. This is a one-time upgrade issue. > " Reference should be part of the commit message. I'll update for the next iteration. Thanks for the remark. BR, Jarkko