public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Hao Jia <jiahao.os@bytedance.com>, Tejun Heo <tj@kernel.org>,
	Zefan Li <lizefan.x@bytedance.com>,
	Johannes Weiner <hannes@cmpxchg.org>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
	bristot@redhat.com, vschneid@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] sched/psi: psi bug fixes and cleanups
Date: Sat, 6 Aug 2022 21:38:29 +0200	[thread overview]
Message-ID: <Yu7DNaeknjO9g9m9@gmail.com> (raw)
In-Reply-To: <20220806120510.96131-1-jiahao.os@bytedance.com>


* Hao Jia <jiahao.os@bytedance.com> wrote:

> These three patches are about PSI.
> patch 1: Fixed PSI statistics error caused by unzeroed memory
> in struct psi_group.
> patch 2 and patch 3 are to clean up some unused functions
> and parameters.
> 
> Hao Jia (3):
>   sched/psi: Zero the memory of struct psi_group
>   sched/psi: Remove unused parameter nbytes of psi_trigger_create()
>   sched/psi: Remove redundant cgroup_psi() when !CONFIG_CGROUPS
> 
>  include/linux/cgroup.h |  5 -----
>  include/linux/psi.h    |  2 +-
>  kernel/cgroup/cgroup.c |  2 +-
>  kernel/sched/psi.c     | 10 +++-------
>  4 files changed, 5 insertions(+), 14 deletions(-)

LGTM, and I suspect the scheduler fix wants to go upstream via the tree 
that introduced the bug, the cgroup tree?

For the series:

   Reviewed-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

  parent reply	other threads:[~2022-08-06 19:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-06 12:05 [PATCH 0/3] sched/psi: psi bug fixes and cleanups Hao Jia
2022-08-06 12:05 ` [PATCH 1/3] sched/psi: Zero the memory of struct psi_group Hao Jia
2022-08-10 15:04   ` Johannes Weiner
2022-08-06 12:05 ` [PATCH 2/3] sched/psi: Remove unused parameter nbytes of psi_trigger_create() Hao Jia
2022-08-10 15:12   ` Johannes Weiner
2022-08-06 12:05 ` [PATCH 3/3] sched/psi: Remove redundant cgroup_psi() when !CONFIG_CGROUPS Hao Jia
2022-08-10 15:13   ` Johannes Weiner
2022-08-06 19:38 ` Ingo Molnar [this message]
2022-08-09 17:37 ` [PATCH 0/3] sched/psi: psi bug fixes and cleanups Tejun Heo
2022-08-10 15:13   ` Johannes Weiner
2022-08-15 20:55 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yu7DNaeknjO9g9m9@gmail.com \
    --to=mingo@kernel.org \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=jiahao.os@bytedance.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox