From: Greg KH <gregkh@linuxfoundation.org>
To: Jiho Chu <jiho.chu@samsung.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
yelini.jeong@samsung.com, myungjoo.ham@samsung.com
Subject: Re: [PATCH 2/9] tirnity: Add dma memory module
Date: Wed, 27 Jul 2022 15:15:25 +0200 [thread overview]
Message-ID: <YuE6bQeTI/pcbLZh@kroah.com> (raw)
In-Reply-To: <20220725065308.2457024-3-jiho.chu@samsung.com>
On Mon, Jul 25, 2022 at 03:53:01PM +0900, Jiho Chu wrote:
> This patch includes memory management module.
>
> It provides abstraction layer to handle DMA buffer.
Again, no abstactions please. Get this working and merged properly
first, before worrying about any sort of additional hardware models or
abstractions. It just makes this so much harder to review and to
determine what you really are, or are not, using here.
So far, it seems you aren't using any of these new abstractions, which
is odd. Or I just can't find them. Either way that's a huge sign this
code is wrong and needs to be cleaned up.
thanks,
greg k-h
next prev parent reply other threads:[~2022-07-27 13:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220725065308epcas1p2f6de3d74792854bb312cca4b310badac@epcas1p2.samsung.com>
2022-07-25 6:52 ` [PATCH 0/9] Samsung Trinity NPU device driver Jiho Chu
2022-07-25 6:53 ` [PATCH 1/9] trinity: Add base driver Jiho Chu
2022-07-27 11:54 ` Krzysztof Kozlowski
2022-07-27 13:22 ` Greg KH
2022-07-28 2:05 ` MyungJoo Ham
2022-09-01 19:04 ` Dafna Hirschfeld
2022-09-02 5:39 ` Greg KH
2022-09-01 18:36 ` Mark Brown
2022-09-02 8:23 ` Jiho Chu
2022-07-25 6:53 ` [PATCH 2/9] tirnity: Add dma memory module Jiho Chu
2022-07-27 13:15 ` Greg KH [this message]
2022-07-25 6:53 ` [PATCH 3/9] trinity: Add load/unload IDU files Jiho Chu
2022-07-27 13:14 ` Greg KH
2022-09-17 7:39 ` Jiho Chu
2022-07-25 6:53 ` [PATCH 4/9] trinity: Add schduler module Jiho Chu
2022-07-27 13:09 ` Greg KH
2022-07-25 6:53 ` [PATCH 5/9] trinity: Add sysfs debugfs module Jiho Chu
2022-07-27 13:25 ` Greg KH
2022-07-25 6:53 ` [PATCH 6/9] trinity: Add pm and ioctl feature Jiho Chu
2022-07-25 6:53 ` [PATCH 7/9] trinity: Add profile module Jiho Chu
2022-07-25 6:53 ` [PATCH 8/9] trinity: Add trace module Jiho Chu
2022-07-25 6:53 ` [PATCH 9/9] MAINTAINERS: add TRINITY driver Jiho Chu
2022-07-25 9:02 ` [PATCH 0/9] Samsung Trinity NPU device driver Greg KH
2022-07-25 9:10 ` Oded Gabbay
2022-07-26 2:09 ` MyungJoo Ham
2022-07-26 6:59 ` Krzysztof Kozlowski
2022-07-26 7:51 ` Arnd Bergmann
2022-07-26 11:24 ` Oded Gabbay
2022-07-29 17:50 ` Pavel Machek
[not found] ` <CGME20220725065308epcas1p2f6de3d74792854bb312cca4b310badac@epcms1p5>
[not found] ` <20220726050305epcms1p5ef19a54322263c768ea71d59da7e2616@epcms1p5>
2022-07-26 14:35 ` 추지호/Robot Intelligence팀(SR)/Staff Engineer/삼성전자
2022-07-26 6:57 ` Krzysztof Kozlowski
2022-07-27 11:51 ` Jiho Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuE6bQeTI/pcbLZh@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=jiho.chu@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=yelini.jeong@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox