From: Peter Zijlstra <peterz@infradead.org>
To: Stanislav Goriainov <goriainov@ispras.ru>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH] objtool: Fix memory leak in create_static_call_section()
Date: Wed, 27 Jul 2022 17:55:16 +0200 [thread overview]
Message-ID: <YuFf5LiWGLH6ul5E@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20220727154825.3427-1-goriainov@ispras.ru>
On Wed, Jul 27, 2022 at 06:48:25PM +0300, Stanislav Goriainov wrote:
> On some paths of function create_static_call_section() the memory,
> allocated for key_name via strdup(), is not freed. Even though this
> is a utility function, and all memory will be freed automatically
> after the process is finished, there is free(key_sym) in some cases,
> so it would be sensible to always deallocate the memory.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
This is a run-once die on error program. This is pointless and most
certainly doesn't 'fix' anything.
prev parent reply other threads:[~2022-07-27 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 15:48 [PATCH] objtool: Fix memory leak in create_static_call_section() Stanislav Goriainov
2022-07-27 15:55 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuFf5LiWGLH6ul5E@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=goriainov@ispras.ru \
--cc=jpoimboe@kernel.org \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox