From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0A0FC04A68 for ; Thu, 28 Jul 2022 06:58:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234444AbiG1G61 (ORCPT ); Thu, 28 Jul 2022 02:58:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233283AbiG1G6Z (ORCPT ); Thu, 28 Jul 2022 02:58:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F6D1558DA for ; Wed, 27 Jul 2022 23:58:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D114C61B03 for ; Thu, 28 Jul 2022 06:58:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8AA5C433D7; Thu, 28 Jul 2022 06:58:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658991504; bh=9VtPWDr71X6cu20A7g8i4Z19oj5u5gdAoplvwb8bcDk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=curQK1W9PBsTNWLk/jhbQnrodc2Ty0zLzbkxqCVkbCgpNHDtpZ/2loC4SEkiuDxBQ QGzRL2Orfu2+1GYvoabCA8qwVYW6Oder7Ll+TISokUjczDizH7xseyenwZA4xs1R/a qpgQF4IK8vKsmn0MFWsCxZ5Xkl9B0maAtb0ti/nc= Date: Thu, 28 Jul 2022 08:58:21 +0200 From: Greg Kroah-Hartman To: Martin Kaiser Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] staging: r8188eu: get da from ieee80211_mgmt Message-ID: References: <20220724153917.138848-1-martin@kaiser.cx> <20220724153917.138848-2-martin@kaiser.cx> <20220728052515.tmzztbha2ckwusd2@viti.kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220728052515.tmzztbha2ckwusd2@viti.kaiser.cx> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 28, 2022 at 07:25:15AM +0200, Martin Kaiser wrote: > Thus wrote Greg Kroah-Hartman (gregkh@linuxfoundation.org): > > > On Sun, Jul 24, 2022 at 05:39:13PM +0200, Martin Kaiser wrote: > > > Define a struct ieee80211_mgmt in the OnAssocRsp function. Read the > > > destination address (da) from this struct. > > > This explains (sortta) what this patch does, but not why you are doing > > this. > > There's a bunch of macros and functions in the r8188eu driver to parse > standard messages. I'm trying to replace these driver-specific versions > with the generic ones that are shared between several drivers. > > This patch removs one get_da call. It's not much but hopefully, we can > eventually remove get_da itself. > > I know that we should leave the parsing of messages to mac80211 and get > rid of OnAssocRsp etc. Until we're at this point, I hope that doing the > parsing ourselves and using the generic helpers is a useful intermediate > step. > > Would it make sense to rewrite the patch description or to summarize the > patches in this series to something like "read some response message > fields from struct ieee80211_mgmt"? As is, the patch description is not acceptable, so yes, it needs to change :) thanks, greg k-h