From: Greg KH <gregkh@linuxfoundation.org>
To: "Datta, Shubhrajyoti" <shubhrajyoti.datta@amd.com>
Cc: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
"jirislaby@kernel.org" <jirislaby@kernel.org>,
"git@xilinx.com" <git@xilinx.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/7] tty: xilinx_uartps: Check the clk_enable return value
Date: Thu, 28 Jul 2022 13:48:44 +0200 [thread overview]
Message-ID: <YuJ3nPM9mhCHFQN2@kroah.com> (raw)
In-Reply-To: <BY5PR12MB49028F76B4701BA309913A6181969@BY5PR12MB4902.namprd12.prod.outlook.com>
On Thu, Jul 28, 2022 at 11:09:10AM +0000, Datta, Shubhrajyoti wrote:
> [AMD Official Use Only - General]
>
> Hi Greg,
>
> > -----Original Message-----
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Sent: Friday, May 6, 2022 2:20 AM
> > To: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> > Cc: linux-serial@vger.kernel.org; michal.simek@xilinx.com;
> > jirislaby@kernel.org; git@xilinx.com; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH 2/7] tty: xilinx_uartps: Check the clk_enable return value
> >
> > On Fri, Apr 29, 2022 at 01:44:17PM +0530, Shubhrajyoti Datta wrote:
> > > Check the clk_enable return value.
> >
> > That says what, but not why.
> >
> Will fix v2.
> > >
> > > Addresses-Coverity: Event check_return.
> >
> > Shouldn't this be a covertity id?
>
> I could not find the warning in the Coverity that is run on the linux kernel.
> Somehow was seeing int when I was running locally.
Ok, then there's no need to reference coverity at all then :)
thanks,
greg k-h
next prev parent reply other threads:[~2022-07-28 11:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 8:14 [PATCH 0/7] tty: xilinx_uartps: fixes and improvements Shubhrajyoti Datta
2022-04-29 8:14 ` [PATCH 1/7] xilinx: Update copyright text to correct format Shubhrajyoti Datta
2022-04-29 8:14 ` [PATCH 2/7] tty: xilinx_uartps: Check the clk_enable return value Shubhrajyoti Datta
2022-05-05 20:50 ` Greg KH
2022-07-28 11:09 ` Datta, Shubhrajyoti
2022-07-28 11:48 ` Greg KH [this message]
2022-04-29 8:14 ` [PATCH 3/7] tty: xilinx_uartps: Add check for runtime_get_sync calls Shubhrajyoti Datta
2022-05-05 20:50 ` Greg KH
2022-05-10 11:53 ` Shubhrajyoti Datta
2022-04-29 8:14 ` [PATCH 4/7] tty: xilinx_uartps: Check clk_enable return value Shubhrajyoti Datta
2022-05-05 20:51 ` Greg KH
2022-04-29 8:14 ` [PATCH 5/7] tty: xilinx_uartps: Make the timeout unsigned Shubhrajyoti Datta
2022-05-05 20:54 ` Greg KH
2022-04-29 8:14 ` [PATCH 6/7] serial: uartps: Fix the ignore_status Shubhrajyoti Datta
2022-05-05 20:55 ` Greg KH
2022-04-29 8:14 ` [PATCH 7/7] serial: uartps: Prevent writes when the controller is disabled Shubhrajyoti Datta
2022-05-05 20:56 ` Greg KH
2022-05-05 20:48 ` [PATCH 0/7] tty: xilinx_uartps: fixes and improvements Greg KH
2022-05-10 11:54 ` Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuJ3nPM9mhCHFQN2@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=git@xilinx.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox