From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E8F5C19F29 for ; Thu, 28 Jul 2022 07:58:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234913AbiG1H6P (ORCPT ); Thu, 28 Jul 2022 03:58:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234883AbiG1H6N (ORCPT ); Thu, 28 Jul 2022 03:58:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9173950738 for ; Thu, 28 Jul 2022 00:58:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3068461B86 for ; Thu, 28 Jul 2022 07:58:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38DE3C433D6; Thu, 28 Jul 2022 07:58:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658995091; bh=NRDlReSxaH3MXcpkruof6LY61Urf42FbUwrqniO6oA4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rxFXZeGimqHr+TZ9ritLDZrBQUdFPgZCr8BvAJMt0cb/h2+5m9X47xDFUr85cy1Or n829ZToOpSDJRZRUe0WPzEtGRCKyl+QbQoE4br3qsoM1iR13Rakm36mtb4rQB5qCcq FfiEzJkY7rnxnS4V6NGa1E9wtiIJ1JqjZVeEQBCk= Date: Thu, 28 Jul 2022 09:58:03 +0200 From: Greg KH To: kah.jing.lee@intel.com Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, rafael.j.wysocki@intel.com, tien.sung.ang@intel.com, dinh.nguyen@intel.com Subject: Re: [PATCH v2 0/3] New driver for Intel(Altera) FPGA System ID softIP Message-ID: References: <20220602122008.3021030-1-kah.jing.lee@intel.com> <20220721123017.416438-1-kah.jing.lee@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220721123017.416438-1-kah.jing.lee@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 21, 2022 at 08:30:19PM +0800, kah.jing.lee@intel.com wrote: > From: Kah Jing Lee > > Hi, > > I would like to request review for the new System ID driver for Intel FPGA > platform. > > New sysid driver for Altera(Intel) Sysid component is generally part of an > FPGA design. The component can be hotplugged when the FPGA is reconfigured. > > There are two basic ways to use the system ID core: > - Verify the system ID before downloading new software to a system. This > method can be used by software development tools, before downloading a > program to a target hardware system, if the program is compiled for > different hardware. > > - Check system ID after reset. If a program is running on hardware other > than the expected Platform Designer system, the program may fail to > function altogether. If the program does not crash, it can behave > erroneously in subtle ways that are difficult to debug. To protect against > this case, a program can compare the expected system ID against the > system ID core, and report an error if they do not match. > > Documentation link: > https://rocketboards.org/foswiki/Documentation/AgilexSoCGSRD#PR_Files > > Feedback from maintainers: > https://lore.kernel.org/lkml/YpmqeHt5Y31ffh5Q@kroah.com/#t That does not describe what changed from the previous version at all, it just points to a response from me saying you all need to work on this driver. thanks, greg k-h