From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEF9BC19F29 for ; Thu, 28 Jul 2022 08:47:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234693AbiG1IrT (ORCPT ); Thu, 28 Jul 2022 04:47:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231783AbiG1IrR (ORCPT ); Thu, 28 Jul 2022 04:47:17 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F84352E67; Thu, 28 Jul 2022 01:47:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4145FB8236D; Thu, 28 Jul 2022 08:47:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 704E4C433C1; Thu, 28 Jul 2022 08:47:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658998034; bh=jCsd0BYUuxQPFCGggo3LU7ymg+rWOZhe5SyLYMPuEII=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sjSBJyeyjGNBExkzleVUKJJqVo66l495ZESo768hjKGH9VbAxM6Xm3sasdnFBW2Sb n3T6EG5M6iwOWhTqD4FIMdgI1abQhslYZZrH59lsDPb7bfQpgL+eW7A0GjxTDOJXRo eje3Y0dy/nhLNejdZ4DX/YsEcnRmQUHHxcDY4BwI= Date: Thu, 28 Jul 2022 10:47:11 +0200 From: Greg KH To: yuji2.ishikawa@toshiba.co.jp Cc: robh+dt@kernel.org, hverkuil@xs4all.nl, nobuhiro1.iwamatsu@toshiba.co.jp, corbet@lwn.net, sumit.semwal@linaro.org, christian.koenig@amd.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH v2 0/5] Add Toshiba Visconti DNN image processing accelerator driver Message-ID: References: <20220722082858.17880-1-yuji2.ishikawa@toshiba.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 26, 2022 at 06:09:50AM +0000, yuji2.ishikawa@toshiba.co.jp wrote: > Hi Greg > > Thank you for your comments. > > > -----Original Message----- > > From: Greg KH > > Sent: Monday, July 25, 2022 9:47 PM > > To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開) > > > > Cc: Rob Herring ; Hans Verkuil ; > > iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) > > ; Jonathan Corbet ; > > Sumit Semwal ; Christian König > > ; linux-arm-kernel@lists.infradead.org; > > linux-kernel@vger.kernel.org; linux-media@vger.kernel.org; > > dri-devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org > > Subject: Re: [PATCH v2 0/5] Add Toshiba Visconti DNN image processing > > accelerator driver > > > > On Fri, Jul 22, 2022 at 05:28:53PM +0900, Yuji Ishikawa wrote: > > > This series is the DNN image processing accelerator driver for Toshiba's ARM > > SoC, Visconti[0]. > > > This provides DT binding documentation, device driver, MAINTAINER files > > and documents. > > > > > > Best regards, > > > Yuji > > > > > > [0]: > > > > > https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image- > > > recognition-processors-visconti.html > > > > > > dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing > > accelerator bindings > > > v1 -> v2: > > > - No update > > > > > > soc: visconti: Add Toshiba Visconti image processing accelerator common > > source > > > v1 -> v2: > > > - checked with checkpatch.pl --strict > > > > > > soc: visconti: Add Toshiba Visconti DNN image processing accelerator > > > v1 -> v2: > > > - checked with checkpatch.pl --strict > > > - removed unused code > > > > > > MAINTAINERS: Add entries for Toshiba Visconti DNN image processing > > > v1 -> v2: > > > - No update > > > > > > Documentation: driver-api: visconti: add a description of DNN driver. > > > v1 -> v2: > > > - newly added documents > > > > > > Yuji Ishikawa (5): > > > dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing > > > accelerator bindings > > > soc: visconti: Add Toshiba Visconti image processing accelerator > > > common source > > > soc: visconti: Add Toshiba Visconti DNN image processing accelerator > > > MAINTAINERS: Add entries for Toshiba Visconti DNN image processing > > > accelerator > > > Documentation: driver-api: visconti: add a description of DNN driver. > > > > > > .../soc/visconti/toshiba,visconti-dnn.yaml | 54 ++ > > > Documentation/driver-api/visconti/common.rst | 115 ++++ > > > Documentation/driver-api/visconti/dnn.rst | 394 +++++++++++++ > > > MAINTAINERS | 2 + > > > drivers/soc/Kconfig | 1 + > > > drivers/soc/Makefile | 1 + > > > drivers/soc/visconti/Kconfig | 7 + > > > drivers/soc/visconti/Makefile | 8 + > > > drivers/soc/visconti/dnn/Makefile | 6 + > > > drivers/soc/visconti/dnn/dnn.c | 523 > > ++++++++++++++++++ > > > drivers/soc/visconti/dnn/hwd_dnn.c | 183 ++++++ > > > drivers/soc/visconti/dnn/hwd_dnn.h | 68 +++ > > > drivers/soc/visconti/dnn/hwd_dnn_reg.h | 228 ++++++++ > > > drivers/soc/visconti/ipa_common.c | 55 ++ > > > drivers/soc/visconti/ipa_common.h | 18 + > > > drivers/soc/visconti/uapi/dnn.h | 77 +++ > > > drivers/soc/visconti/uapi/ipa.h | 90 +++ > > > > Why is this in drivers/soc/? > > Actually, I'm not sure where his module should live in. > The directory drivers/soc were chosen just because the driver is specific to Visconti SoC. > Is it better to move the driver to another directory such as drivers/misc ? Yes please start out in drivers/misc/ unless we find a better place for it. thanks, greg k-h