From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62B32C04A68 for ; Thu, 28 Jul 2022 11:14:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234730AbiG1LO3 (ORCPT ); Thu, 28 Jul 2022 07:14:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236609AbiG1LO0 (ORCPT ); Thu, 28 Jul 2022 07:14:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E9D266AE4 for ; Thu, 28 Jul 2022 04:14:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E0EF961A4E for ; Thu, 28 Jul 2022 11:14:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 768CAC433D6; Thu, 28 Jul 2022 11:14:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659006865; bh=oXhKn484H8C4pSVsSAWT8FrTdxHfNXnO2/Oj96hh46g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ecLDfjwfJxwxl7WL4Paa0dE9dnRnnddjlcSZ5n7EytRN8TpOVVUzlbYgO5njHL4uL FCpXsWxfjmdoqcX8cwxnN+XMiJTBZPm2i7Bs1kv+jvtOEuJTQQoHcPXv3aAa47SE4G PkxRIClibkhbMKJTF3jxT62/AshODfms/IA+1zds2vSoRyci+nVCaaDeFPOYUM4ve9 7ck3gppV/uCUadE3BN+hMbddSeqp0rBBOJg4EkYgO6ZvKsH0tC/qqSwFD/eU9psQCp m2Tr9bd4tRyt8OJR/TzHrrAM6sSQB/EecxcgLFp4rHrsZg1ZjsnbHttkz+XwA/5hDS 8U+zgAsmgx8cQ== Date: Thu, 28 Jul 2022 12:14:19 +0100 From: Mark Brown To: "Prasad, Prasad" Cc: Takashi Iwai , "alsa-devel@alsa-project.org" , "Reddy, V sujith kumar" , "Mukunda, Vijendar" , "Hiregoudar, Basavaraj" , "Dommati, Sunil-kumar" , "Saba Kareem, Syed" , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Charles Keepax , Yang Yingliang , open list Subject: Re: [PATCH v2] ASoC: amd: acp: Initialize list to store acp_stream during pcm_open Message-ID: References: <20220722133530.3314087-1-venkataprasad.potturu@amd.com> <87h739464x.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="djlTOc+vqayQK83P" Content-Disposition: inline In-Reply-To: X-Cookie: People respond to people who respond. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --djlTOc+vqayQK83P Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 28, 2022 at 07:52:25AM +0000, Prasad, Prasad wrote: > linked to multiple pcm device as we will have same dai->driver id >=20 > or array index for multiple pcm open. Initialize new linked list >=20 > stream_list to store opened pcm stream info dynamically. >=20 >=20 >=20 > If an IRQ handler refers to the linked list, make sure that no list >=20 > change will happen concurrently during the IRQ handling. It seems >=20 > that you have no protection for it yet. > Yes, linked list may changes concurrently during IRQ handling, we will us= e spin locks in the next version of patch. Please fix your mail client to clearly identify quoted text, it's very hard to read your mails since (among other things) it's hard to tell what text you added. --djlTOc+vqayQK83P Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLib4oACgkQJNaLcl1U h9CUMQf7BkXcYCSXzOPB2U5KyrOlXFxo/iePJ+LMnwXcK6XPHGwNqfIl3iQ2kBzz HNgn7TA4mo7cKULBTZrXb3yx7Gn+lRYsZ/PfMQLbOX5hjUhGqEJEZA/6HxQkiP6J ++vIRGFtrqlNXV8emSJAurT1m6IikCD4PAmJOPyTzNHWHV9j1U7dfEwfY2XSxfSb j9cB3geRNNb+jHxls+s8KTa/3E83/Krkyq1sAKH1UklL7X71KR4R9k1M3RU2ZP3o 4jAXneq6kLpEog7YnKsnASVbRZfdhxvO6WiISeHygrtESt5UvwTTWK68uh6QowvZ cfDSAD0IJDBtvzFofrJ5HDbVfQgU4Q== =/414 -----END PGP SIGNATURE----- --djlTOc+vqayQK83P--