Re: [RFC PATCH v4 0/8] hugetlb: Change huge pmd sharing synchronization again

Ray Fucillo
2022-07-20T14:49:49Z

> On Jul 6, 2022, at 4:23 PM, Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
> I am sending this as a RFC once more in the hope of generating comments
> and discussion. While the changes are intrusive, they do show a significant
> performance benefit in my simulated workload. Code is based on next-20220706.
>
> hugetlb fault scalability regressions have recently been reported [1].
> This is not the first such report, as regressions were also noted when
> commit c0d0381ade79 ("hugetlbfs: use i_mmap_rwsem for more pmd sharing
> synchronization") was added [2] in v5.7. At that time, a proposal to
> address the regression was suggested [3] but went nowhere.
>
> The regression and benefit of this patch series is not evident when
> using the vm_scalability benchmark reported in [2] on a recent kernel.
> Results from running,

Mike, thank you for all the work and careful consideration here! We did find that this patch set addresses the scalability regression that was at the root of critical issues for customers that upgraded to newer Linux distributions (those with commit c0d0381ade79)

Ray