From: Christoph Hellwig <hch@infradead.org>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
Song Liu <song@kernel.org>, Christoph Hellwig <hch@infradead.org>,
Guoqing Jiang <guoqing.jiang@linux.dev>,
Stephen Bates <sbates@raithlin.com>,
Martin Oliveira <Martin.Oliveira@eideticom.com>,
David Sloan <David.Sloan@eideticom.com>
Subject: Re: [PATCH 5/5] md/raid5: Ensure batch_last is released before sleeping for quiesce
Date: Thu, 28 Jul 2022 07:15:51 -0700 [thread overview]
Message-ID: <YuKaF99Da1vqpqVP@infradead.org> (raw)
In-Reply-To: <20220727210600.120221-6-logang@deltatee.com>
On Wed, Jul 27, 2022 at 03:06:00PM -0600, Logan Gunthorpe wrote:
> +static struct stripe_head *__raid5_get_active_stripe(struct r5conf *conf,
> + struct stripe_request_ctx *ctx, sector_t sector,
> + bool previous, bool noblock, bool noquiesce)
Passing three different bool arguments right after another is a really
confusing calling convention, at some point this should become a set of
flags. I'd also drop the __raid5_get_active_stripe vs
raid5_get_active_stripe distinction.
next prev parent reply other threads:[~2022-07-28 14:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 21:05 [PATCH 0/5] Bug fix for recent batching change Logan Gunthorpe
2022-07-27 21:05 ` [PATCH 1/5] md/raid5: Refactor raid5_get_active_stripe() Logan Gunthorpe
2022-07-28 14:13 ` Christoph Hellwig
2022-07-29 22:48 ` Song Liu
2022-08-01 11:47 ` Logan Gunthorpe
2022-08-01 16:49 ` Song Liu
2022-08-01 17:15 ` Christoph Hellwig
2022-08-01 20:50 ` Song Liu
2022-07-27 21:05 ` [PATCH 2/5] md/raid5: Make is_inactive_blocked() helper Logan Gunthorpe
2022-07-28 14:14 ` Christoph Hellwig
2022-07-27 21:05 ` [PATCH 3/5] md/raid5: Drop unnecessary call to r5c_check_stripe_cache_usage() Logan Gunthorpe
2022-07-27 21:05 ` [PATCH 4/5] md/raid5: Move stripe_request_ctx up Logan Gunthorpe
2022-07-27 21:06 ` [PATCH 5/5] md/raid5: Ensure batch_last is released before sleeping for quiesce Logan Gunthorpe
2022-07-28 14:15 ` Christoph Hellwig [this message]
2022-07-28 5:55 ` [PATCH 0/5] Bug fix for recent batching change Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuKaF99Da1vqpqVP@infradead.org \
--to=hch@infradead.org \
--cc=David.Sloan@eideticom.com \
--cc=Martin.Oliveira@eideticom.com \
--cc=guoqing.jiang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=sbates@raithlin.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox