* [PATCH] staging: pi433: fix wrong comment
@ 2022-07-29 15:25 Sidong Yang
2022-07-29 15:36 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Sidong Yang @ 2022-07-29 15:25 UTC (permalink / raw)
To: Greg Kroah-Hartman, Paulo Miguel Almeida
Cc: Sidong Yang, linux-staging, linux-kernel
The comment should describe the error when user calls rf69_write_fifo()
not rf69_write_fifo().
Signed-off-by: Sidong Yang <realwakka@gmail.com>
---
drivers/staging/pi433/rf69.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 659c8c1b38fd..8c7fab6a46bb 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -816,7 +816,7 @@ int rf69_write_fifo(struct spi_device *spi, u8 *buffer, unsigned int size)
if (size > FIFO_SIZE) {
dev_dbg(&spi->dev,
- "read fifo: passed in buffer bigger then internal buffer\n");
+ "write fifo: passed in buffer bigger then internal buffer\n");
return -EMSGSIZE;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: pi433: fix wrong comment
2022-07-29 15:25 [PATCH] staging: pi433: fix wrong comment Sidong Yang
@ 2022-07-29 15:36 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2022-07-29 15:36 UTC (permalink / raw)
To: Sidong Yang; +Cc: Paulo Miguel Almeida, linux-staging, linux-kernel
On Fri, Jul 29, 2022 at 04:25:54PM +0100, Sidong Yang wrote:
> The comment should describe the error when user calls rf69_write_fifo()
> not rf69_write_fifo().
>
> Signed-off-by: Sidong Yang <realwakka@gmail.com>
> ---
> drivers/staging/pi433/rf69.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index 659c8c1b38fd..8c7fab6a46bb 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -816,7 +816,7 @@ int rf69_write_fifo(struct spi_device *spi, u8 *buffer, unsigned int size)
>
> if (size > FIFO_SIZE) {
> dev_dbg(&spi->dev,
> - "read fifo: passed in buffer bigger then internal buffer\n");
> + "write fifo: passed in buffer bigger then internal buffer\n");
This is not a comment.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-29 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-29 15:25 [PATCH] staging: pi433: fix wrong comment Sidong Yang
2022-07-29 15:36 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox