From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Luca Ellero <luca.ellero@brickedbrain.com>,
dmitry.torokhov@gmail.com, daniel@zonque.org,
m.felsch@pengutronix.de, mkl@pengutronix.de,
miquel.raynal@bootlin.com, imre.deak@nokia.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Luca Ellero <l.ellero@asem.it>
Subject: Re: [PATCH v2 1/3] ads7846: don't report pressure for ads7845
Date: Fri, 29 Jul 2022 16:50:56 +0300 [thread overview]
Message-ID: <YuPlwMP+W1zGKG1D@smile.fi.intel.com> (raw)
In-Reply-To: <20220721204835.fobidbnsvhea7r3w@pengutronix.de>
On Thu, Jul 21, 2022 at 10:48:35PM +0200, Uwe Kleine-König wrote:
> On Thu, Jul 21, 2022 at 10:34:56AM +0200, Luca Ellero wrote:
> > From: Luca Ellero <l.ellero@asem.it>
> >
> > ADS7845 doesn't support pressure.
> > This patch avoids the following error reported by libinput-list-devices:
> > "ADS7845 Touchscreen: kernel bug: device has min == max on ABS_PRESSURE".
> >
> > Signed-off-by: Luca Ellero <l.ellero@asem.it>
>
> I don't know how picky Dmitry is, but some maintainers would ask you to
> either add a Signed-off-by with the email address you sent this patch
> from, or make sure to send it from the asem.it address.
It's fine to be sent from different email of the same person.
But like you said, some maintainers are really picky and that
may block contribution (I have been seen a case, where actually
allowing to do as above unblocks contribution since person can't
re-sent properly the change from another address by some reasons).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-07-29 13:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 8:34 [PATCH v2 0/3] ads7846: fix support for ADS7845 Luca Ellero
2022-07-21 8:34 ` [PATCH v2 1/3] ads7846: don't report pressure for ads7845 Luca Ellero
2022-07-21 20:48 ` Uwe Kleine-König
2022-07-22 9:33 ` Luca Ellero
2022-07-29 13:50 ` Andy Shevchenko [this message]
2022-08-01 7:02 ` Luca Ellero
2022-07-21 8:34 ` [PATCH v2 2/3] ads7846: always set last command to PWRDOWN Luca Ellero
2022-07-21 8:34 ` [PATCH v2 3/3] ads7846: don't check penirq immediately for 7845 Luca Ellero
2022-07-29 13:52 ` [PATCH v2 0/3] ads7846: fix support for ADS7845 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuPlwMP+W1zGKG1D@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=daniel@zonque.org \
--cc=dmitry.torokhov@gmail.com \
--cc=imre.deak@nokia.com \
--cc=l.ellero@asem.it \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ellero@brickedbrain.com \
--cc=m.felsch@pengutronix.de \
--cc=miquel.raynal@bootlin.com \
--cc=mkl@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox