Re: [PATCH v5 0/5] cover-letter: Simplify vfio_iommu_type1 attach/detach routine

Nicolin Chen
2022-07-26T18:32:58Z

On Wed, Jul 13, 2022 at 04:57:36PM -0700, Nicolin Chen wrote:

> > > > > This is on github:
> > > > > https://github.com/nicolinc/iommufd/commits/vfio_iommu_attach
> > > >
> > > > How do you foresee this going in, I'm imagining Joerg would merge the
> > > > first patch via the IOMMU tree and provide a topic branch that I'd
> > > > merge into the vfio tree along with the remaining patches. Sound
> > > > right? Thanks,
> > >
> > > We don't have any build dependency between the IOMMU change and
> > > VFIO changes, yet, without the IOMMU one, any iommu_attach_group()
> > > failure now would be a hard failure without a chance falling back
> > > to a new_domain, which is slightly different from the current flow.
> > >
> > > For a potential existing use case that relies on reusing existing
> > > domain, I think it'd be safer to have Joerg acking the first change
> > > so you merge them all? Thank!
> >
> > Works for me, I'll look for buy-in + ack from Joerg. Thanks,
> >
> > Alex
>
> Joerg, would it be possible for you to ack at the IOMMU patch?

Joerg, sorry for pinning again. Would it be possible for you
to give an ack at the IOMMU patch so that this series might
catch the last train of this cycle? Thanks!