From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E6F2C19F2B for ; Fri, 29 Jul 2022 23:29:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232277AbiG2X3O (ORCPT ); Fri, 29 Jul 2022 19:29:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231536AbiG2X3J (ORCPT ); Fri, 29 Jul 2022 19:29:09 -0400 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAEB448CA5 for ; Fri, 29 Jul 2022 16:29:08 -0700 (PDT) Received: by mail-io1-xd32.google.com with SMTP id 125so4687294iou.6 for ; Fri, 29 Jul 2022 16:29:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=csp-edu.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=qWNh7vOk9tCkYV94WwXKMJ4uEd3sFIr85O9CxOfUKiQ=; b=wQRaueezeuI5pT4oYhFHZhZMItthSUgguL7GFYaB68jVps//cv0JYxK90b/gVoI05n h8dk3+3t6WieMLwz6z1FkKimPbVmxBxmwHfZ2H2GauMe/JDVDscps2uZS6q2n5ehoxyw K54ymHUibx6A+RwjmsE+sATpqcBcstkpP+aMgjfMXtSD1T7G06Bm/3FjtmkNfhzv8Yxq zj3bPFJ9BbBbJ5lQtFHs3M4iw3Y8yxFUXHwDZvz4iUR1t+dFmIS535MsNySc4XOqDTJN AzfiIGVwL8pvMskr8ehS/xgY2ZzFjfGB0VG+4x4NwHQxpcKiTtHsv6uQyoYdrTZlQsBx 13sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=qWNh7vOk9tCkYV94WwXKMJ4uEd3sFIr85O9CxOfUKiQ=; b=d309yK/1ZwSPjkoxR0KIPHRWHO9cua6s5q7UCxSe6FMAc9Vrn2TIWvvdPz5tK5X05t CZxRbCvTIikE3d//pvVN9ewhDddcFQOun4kgy4K0YJeh8y2VDX8N0Pyji83xTs8zK32w ZJp9Z+Ow81n0VMwXGBJoTILkMPhSbNjpi8d8HmtE9/CgZEFEWZ3PzYSGY3MbYlO9Fql2 4MhOGonFnu6M3s/g+Tp4DdZDZIz7AhIz+V6OPZxgkNP/EJMKYtxVIZs9mEX9YTkrnCgv +Hoq589FZou3Xw8mTFXIEkNQLqfDftU2BdpXTZO5VrpYH9CGOy7m4J2WQkGLte/wYr0D dp7g== X-Gm-Message-State: AJIora8Fkid+fWSgrCl+lWnDIoyig1Oc15aFcQIBOzk7on+2Lkbzjm7k TB4RhqRdm0SOtpGhYVX+eqMblg== X-Google-Smtp-Source: AGRyM1uRQjDAUWSoc11u2QbNyEFqJJaHT/kHhRAen2+cI88tCY46m5+6iYzrx08XaKia2PfQSYlqDA== X-Received: by 2002:a05:6638:12d4:b0:33f:aaab:8d84 with SMTP id v20-20020a05663812d400b0033faaab8d84mr2274213jas.67.1659137348018; Fri, 29 Jul 2022 16:29:08 -0700 (PDT) Received: from kernel-dev-1 (75-168-113-69.mpls.qwest.net. [75.168.113.69]) by smtp.gmail.com with ESMTPSA id y14-20020a5e870e000000b0067bd7f5f964sm2244967ioj.7.2022.07.29.16.29.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jul 2022 16:29:07 -0700 (PDT) Date: Fri, 29 Jul 2022 18:29:07 -0500 From: Coleman Dietsch To: Greg KH Cc: kvm@vger.kernel.org, x86@kernel.org, Sean Christopherson , Dave Hansen , linux-kernel@vger.kernel.org, syzbot+e54f930ed78eb0f85281@syzkaller.appspotmail.com, Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Paolo Bonzini , Thomas Gleixner , Pavel Skripkin , linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH] KVM: x86/xen: Fix bug in kvm_xen_vcpu_set_attr() Message-ID: References: <20220728194736.383727-1-dietschc@csp.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 29, 2022 at 09:41:02AM +0200, Greg KH wrote: > On Thu, Jul 28, 2022 at 02:47:37PM -0500, Coleman Dietsch wrote: > > This crash appears to be happening when vcpu->arch.xen.timer is already set and kvm_xen_init_timer(vcpu) is called. > > What does "this crash" refer to ? > > > > > During testing with the syzbot reproducer code it seemed apparent that the else if statement in the KVM_XEN_VCPU_ATTR_TYPE_TIMER switch case was not being reached, which is where the kvm_xen_stop_timer(vcpu) call is located. > > Please properly wrap your kernel changelog at 72 columns. > > Didn't checkpatch.pl complain about this? > I believe I made the mistake of editing the patch file directly so it was on me for forgetting to run checkpatch.pl manually. > thanks, > > greg k-h Thanks for the feedback Greg, I believe I have (at least these) issues resolved in the next version of the patch.