From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31D51C19F28 for ; Sat, 30 Jul 2022 23:16:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235459AbiG3XQK (ORCPT ); Sat, 30 Jul 2022 19:16:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230432AbiG3XQI (ORCPT ); Sat, 30 Jul 2022 19:16:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AA6365F5 for ; Sat, 30 Jul 2022 16:16:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D7E3260FCB for ; Sat, 30 Jul 2022 23:16:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C887C433C1; Sat, 30 Jul 2022 23:16:05 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="SUdHm9Vd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1659222963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AzCdRPj05yjL8h85+6gig1pAniprat2lIv4CqlJ0538=; b=SUdHm9VdcBySkgCGqKK/SvTxdxaNdVZYwa4T1eNvhkLbUlm7F3tOQ3EUNsh2phAGbQZx2K VBQPiV/0m3zyeXpM22Lvzg5igCOEd8/snd4QY65ABaVLJjBe5TyR+HHiFg1q+GpSAmuq2k zigzuYJno3uB5FW3QMZon4YKaeGjwMs= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id f4e515bd (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 30 Jul 2022 23:16:03 +0000 (UTC) Date: Sun, 31 Jul 2022 01:15:59 +0200 From: "Jason A. Donenfeld" To: Greg Kroah-Hartman Cc: Arnd Bergmann , Ard Biesheuvel , kernel test robot , "Justin M. Forbes" , clang-built-linux , kbuild-all@lists.01.org, Linux Kernel Mailing List , "Jason A. Donenfeld" Subject: Re: [linux-stable-rc:linux-5.15.y 6874/8723] arch/arm/lib/xor-neon.c:30:2: warning: This code requires at least version 4.6 of GCC Message-ID: References: <202207250449.BYMZbIA2-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 30, 2022 at 04:33:28PM +0200, Greg Kroah-Hartman wrote: > On Mon, Jul 25, 2022 at 04:35:38PM +0200, Arnd Bergmann wrote: > > On Mon, Jul 25, 2022 at 2:55 PM Arnd Bergmann wrote: > > > > > The other easy workaround would be to just turn off the xor-neon code > > > when building with clang, e.g. using this Makefile hack: > > > > > > diff --git a/arch/arm/lib/Makefile b/arch/arm/lib/Makefile > > > index 6d2ba454f25b..8e4fe6421dd2 100644 > > > --- a/arch/arm/lib/Makefile > > > +++ b/arch/arm/lib/Makefile > > > @@ -43,8 +43,10 @@ endif > > > $(obj)/csumpartialcopy.o: $(obj)/csumpartialcopygeneric.S > > > $(obj)/csumpartialcopyuser.o: $(obj)/csumpartialcopygeneric.S > > > > > > +ifdef CONFIG_CC_IS_CLANG > > > ifeq ($(CONFIG_KERNEL_MODE_NEON),y) > > > NEON_FLAGS := -march=armv7-a -mfloat-abi=softfp -mfpu=neon > > > CFLAGS_xor-neon.o += $(NEON_FLAGS) > > > obj-$(CONFIG_XOR_BLOCKS) += xor-neon.o > > > endif > > > +endif > > > > Nevermind, this does not actually work. Just turning off the warning > > is probably best then, as actually disabling this code would still > > be invasive not do much beyond saving a little bit of kernel .text size. > > Ok, if it triggers again, and I get annoyed, I'll write a patch, > otherwise I'll just leave it alone unless someone else wants to send it > to me... The patch is trivial, if your idea is just to remove the #warning, right? Might as well just do it now and get it over with. Jason