From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Arnd Bergmann <arnd@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
kernel test robot <lkp@intel.com>,
"Justin M. Forbes" <jforbes@fedoraproject.org>,
clang-built-linux <llvm@lists.linux.dev>,
kbuild-all@lists.01.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Jason A. Donenfeld" <zx2c4@kernel.org>
Subject: Re: [linux-stable-rc:linux-5.15.y 6874/8723] arch/arm/lib/xor-neon.c:30:2: warning: This code requires at least version 4.6 of GCC
Date: Sun, 31 Jul 2022 12:13:14 +0200 [thread overview]
Message-ID: <YuZVuutjt9HcJuGh@kroah.com> (raw)
In-Reply-To: <YuW7r1pyBAeNKlPG@zx2c4.com>
On Sun, Jul 31, 2022 at 01:15:59AM +0200, Jason A. Donenfeld wrote:
> On Sat, Jul 30, 2022 at 04:33:28PM +0200, Greg Kroah-Hartman wrote:
> > On Mon, Jul 25, 2022 at 04:35:38PM +0200, Arnd Bergmann wrote:
> > > On Mon, Jul 25, 2022 at 2:55 PM Arnd Bergmann <arnd@kernel.org> wrote:
> > >
> > > > The other easy workaround would be to just turn off the xor-neon code
> > > > when building with clang, e.g. using this Makefile hack:
> > > >
> > > > diff --git a/arch/arm/lib/Makefile b/arch/arm/lib/Makefile
> > > > index 6d2ba454f25b..8e4fe6421dd2 100644
> > > > --- a/arch/arm/lib/Makefile
> > > > +++ b/arch/arm/lib/Makefile
> > > > @@ -43,8 +43,10 @@ endif
> > > > $(obj)/csumpartialcopy.o: $(obj)/csumpartialcopygeneric.S
> > > > $(obj)/csumpartialcopyuser.o: $(obj)/csumpartialcopygeneric.S
> > > >
> > > > +ifdef CONFIG_CC_IS_CLANG
> > > > ifeq ($(CONFIG_KERNEL_MODE_NEON),y)
> > > > NEON_FLAGS := -march=armv7-a -mfloat-abi=softfp -mfpu=neon
> > > > CFLAGS_xor-neon.o += $(NEON_FLAGS)
> > > > obj-$(CONFIG_XOR_BLOCKS) += xor-neon.o
> > > > endif
> > > > +endif
> > >
> > > Nevermind, this does not actually work. Just turning off the warning
> > > is probably best then, as actually disabling this code would still
> > > be invasive not do much beyond saving a little bit of kernel .text size.
> >
> > Ok, if it triggers again, and I get annoyed, I'll write a patch,
> > otherwise I'll just leave it alone unless someone else wants to send it
> > to me...
>
> The patch is trivial, if your idea is just to remove the #warning,
> right? Might as well just do it now and get it over with.
Fine, I was being lazy :)
Now sent out:
https://lore.kernel.org/all/20220731100551.3679874-1-gregkh@linuxfoundation.org/
next prev parent reply other threads:[~2022-07-31 10:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-24 20:14 [linux-stable-rc:linux-5.15.y 6874/8723] arch/arm/lib/xor-neon.c:30:2: warning: This code requires at least version 4.6 of GCC kernel test robot
2022-07-24 22:39 ` Jason A. Donenfeld
2022-07-25 5:42 ` Ard Biesheuvel
2022-07-25 8:49 ` Greg Kroah-Hartman
2022-07-25 12:41 ` Ard Biesheuvel
2022-07-25 12:55 ` Arnd Bergmann
2022-07-25 14:35 ` Arnd Bergmann
2022-07-30 14:33 ` Greg Kroah-Hartman
2022-07-30 23:15 ` Jason A. Donenfeld
2022-07-31 10:13 ` Greg Kroah-Hartman [this message]
2022-07-25 12:59 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuZVuutjt9HcJuGh@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=arnd@kernel.org \
--cc=jforbes@fedoraproject.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=zx2c4@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox